-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle bom in text and json #1739
Conversation
I would really love to see this change accepted, I'm in the exact same case where I can't upgrade to 3.0 now but I don't like too much to patch it on my side. |
Normally the process have been that at least 2 core members needs to review and accept, if at least 2 agrees then we will merge. we also don't do so much in the v2 branch anymore unless it's a security issue. ping @LinusU
any particular reason why you can't update? Another suggestion is just to update your nodejs version to v18/20 that have fetch built in, so no dependencies hare needed. v20 is required if you want to replace the ways you get blob/files backed up by the file system. for instance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! 👍
🎉 This PR is included in version 2.6.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This reverts commit 29909d7.
@jon-esperanza the breakage was not intentional, we are reverting this now. Thank you for bringing this to our attention. revert progress: #1741 |
Is there any status on this one, then? Is it abandoned? It's marked as merged, but seems to be reverted. |
Yes. it's reverted b/c it broke backward comp. Must come up with a own solution that strips BOM manually without using it. |
Purpose
Bring the fix https://github.com/node-fetch/node-fetch/pull/1482/commits from 3.X to 2.X
Changes
Allow parsing results with BOM encoding
Additional information
It's just a copy paste of the fix of https://github.com/node-fetch/node-fetch/pull/1482/commits for node-fetch 2.X, for the people who can't use 3.X