Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Go embed feature to make Lua scripts easier to maintain #155

Open
1 of 2 tasks
git-hulk opened this issue Aug 19, 2022 · 3 comments
Open
1 of 2 tasks

Use the Go embed feature to make Lua scripts easier to maintain #155

git-hulk opened this issue Aug 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@git-hulk
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Currently, we wrote Lua scripts as plain text which is NOT easy to read,
we can use embed package to separate them into a singe file.

Solution

Use the single Lua file to maintain those scripts.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@git-hulk git-hulk added the enhancement New feature or request label Aug 19, 2022
@Napoleon0621
Copy link
Contributor

Hi @git-hulk,
Just want to make sure if this is the right package to use? https://github.com/Shopify/go-lua

@git-hulk
Copy link
Member Author

git-hulk commented Sep 1, 2022

@Napoleon0621 Can leave this in low priority

@Napoleon0621
Copy link
Contributor

Napoleon0621 commented Sep 1, 2022 •
edited

Ok, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@git-hulk @Napoleon0621