[bitnami/etcd] Add loadBalancerClass for Etcd chart #30697
Merged
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykyta Sigevsky <nick.sigevsky@gmail.com>
sigevsky
force-pushed
the
etcd_add_loadbalancerclass
branch
from
839bb4b
to
a5bff9f
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
carrodher
added
verify
dgomezleon
reviewed
Dec 2, 2024
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: David Gomez <davidbhlm@gmail.com> Signed-off-by: Mykyta Sigevsky <nick.sigevsky@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
dgomezleon
approved these changes
Dec 2, 2024
|
Thanks for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adding a missing loadBalancerClass to etcd's service definition
Benefits
This feature is necessary if one decides to expose etcd's service with a load balancer different from a default. For example, exposing etcd via Tailscale network https://tailscale.com/kb/1439/kubernetes-operator-cluster-ingress#exposing-a-cluster-workload-via-a-tailscale-load-balancer-service.
Possible drawbacks
None
Applicable issue
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm