Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/moodle] Use default moodle db env vars in post-init.d script #68054 #68066

Closed
wants to merge 0 commits into from
Closed

[bitnami/moodle] Use default moodle db env vars in post-init.d script #68054 #68066

wants to merge 0 commits into from

Conversation

ThomasRasmussen
Copy link

Description of the change

When mounting post-init sql scripts, use MOODLE_DATABASE environment variables by default unless the MARIADB environment variables have been specified.

Benefits

Allow easier configuration of the moodle installation as we use the same database user that moodle will use to connect.

Possible drawbacks

If for some reason you need to run something as root user, then you need to specify these credentials.

Applicable issues

Additional information

@github-actions github-actions bot added moodle triage Triage is needed labels Jun 25, 2024
@github-actions github-actions bot requested a review from javsalgar June 25, 2024 10:53
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 25, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 25, 2024
@github-actions github-actions bot removed the request for review from javsalgar June 25, 2024 16:09
@rafariossaa
Copy link
Contributor

Hi,
Sorry for the long delay.
Thanks for your PR. I was looking on how could I integrate this into our CI, but unfortunately this kind of modifications are not supported right now, so I can not merged this change.
As you tried to simplify, the only way right now is to indicate the user credentials in MOODLE_xxx and MARIADB_xxx environment variables.
I opened an internal task to look for some improvement in this area, but I can not provide an ETA for it.

@carrodher carrodher removed the request for review from rafariossaa July 31, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa requested changes

Assignees
No one assigned
Labels
moodle solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/moodle] sql-script in post-init.d should use exising database environment variables
4 participants
@ThomasRasmussen @rafariossaa @javsalgar @carrodher