Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt memos in additional Bitshares operations #210

Closed
grctest opened this issue Sep 21, 2022 · 2 comments
Closed

Encrypt memos in additional Bitshares operations #210

grctest opened this issue Sep 21, 2022 · 2 comments

Comments

@grctest
Copy link
Contributor

grctest commented Sep 21, 2022

Is your feature request related to a problem? Please describe.
If a memo is present in a transfer operation we will encrypt it (unless the op is configured not to be encrypted).

In operations asset_issue, withdraw_permission_claim and override_transfer there are also memo fields (some optional) however the current Beet implementation does not attempt to encrypt these memo fields.

Describe the solution you'd like
If a memo exists in a Bitshares operation, make sure it's handled properly instead of broadcast plaintext erroneously.

Describe alternatives you've considered
Not to take action.

Additional context
Transfer operation only recently added support for the encrypted memo field.

@grctest
Copy link
Contributor Author

grctest commented Sep 23, 2022

The injectedcall function now supports this encrypted memo field in this PR: #207

@grctest
Copy link
Contributor Author

grctest commented Nov 21, 2022

Now included in #222

@grctest grctest closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant