Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated Files #1219

Closed
2 of 14 tasks
ryanRfox opened this issue Aug 2, 2018 · 8 comments
Closed
2 of 14 tasks

Remove Deprecated Files #1219

ryanRfox opened this issue Aug 2, 2018 · 8 comments
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 4a Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists 6 Build Impact flag identifying the build process 6 UX Impact flag identifying the User Interface (UX)
Milestone
3.1.0 - Feature R...

Comments

@ryanRfox
Copy link
Contributor

ryanRfox commented Aug 2, 2018 •
edited by abitmore
Loading

User Story
As a git user I want the repository to contain only current relevant files to mitigate confusion caused by deprecated files.

Proposed Files to Remove

If checked, Core Team has reached consensus for removal

  • /gui_version
  • /testnet-shared-*
    • Remove only from master branch
    • May require update to Git Flow tasks
  • /Vagrantfile
  • /Other (please review other sub-directories and comment below indicating what is deprecated)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cifer-lee
    • Estimated: TBD
  • Perform QA/Testing
  • Update Documentation
@ryanRfox ryanRfox added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2a Discussion Needed Prompt for team to discuss at next stand up. 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 4a Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists 6 Build Impact flag identifying the build process 6 UX Impact flag identifying the User Interface (UX) labels Aug 2, 2018
@ryanRfox ryanRfox self-assigned this Aug 2, 2018
@windycrypto
Copy link
Member

I'd be willing to claim this issue :D

@oxarbitrage
Copy link
Member

@cifer-lee lets leave this one to @ryanRfox , he is already assigned to it. thanks.

@windycrypto
Copy link
Member

oh sorry, not noticed it

@ryanRfox
Copy link
Contributor Author

ryanRfox commented Aug 3, 2018

@cifer-lee what I really need is the discussion about what files are in fact deprecated. Also, someone to go into the CMake files and remove unneeded stuff. I'm not qualified to do this beyond what I've suggested in the description above.

I am happy to assign you to this ticket. Let's start with 1 hour of research, then let's connect to determine what a proper estimate should be to complete it.

@ryanRfox ryanRfox added 2b Gathering Requirements Status indicating currently refining User Stories and defining Requirements and removed 2a Discussion Needed Prompt for team to discuss at next stand up. labels Aug 3, 2018
@ryanRfox ryanRfox assigned windycrypto and unassigned ryanRfox Aug 6, 2018
@ryanRfox ryanRfox added 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution and removed 2b Gathering Requirements Status indicating currently refining User Stories and defining Requirements labels Aug 10, 2018
@pmconrad pmconrad mentioned this issue Apr 28, 2019
Merged
@MichelSantos MichelSantos mentioned this issue May 1, 2019
Closed
@abitmore
Copy link
Member

I consider this as fixed, since the gui_version file and testnet files were removed already, although don't know what the VagrantFile is.

@oxarbitrage
Copy link
Member

Vagrantfile seems to be using boost 1.57(not supported anymore) and pulling stuff from cryptonomex. We could update or just remove it, nobody complained so probably nobody will miss it.

@abitmore
Copy link
Member

abitmore commented Sep 12, 2019 •
edited
Loading

I guess it's replaced by Docker nowadays. Update: it's different.

@oxarbitrage oxarbitrage mentioned this issue Sep 12, 2019
Merged
@oxarbitrage
Copy link
Member

Its old as hell, never saw a single person using it. i think we can just delete. PR opened for it.

@MichelSantos MichelSantos mentioned this issue Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 4a Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists 6 Build Impact flag identifying the build process 6 UX Impact flag identifying the User Interface (UX)
Projects
None yet
Milestone
3.1.0 - Feature Release
Development

No branches or pull requests
4 participants
@windycrypto @abitmore @ryanRfox @oxarbitrage