Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli list_account_balances throw err #1307

Closed
86chenjie opened this issue Sep 7, 2018 · 7 comments
Closed

cli list_account_balances throw err #1307

86chenjie opened this issue Sep 7, 2018 · 7 comments
Assignees
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 CLI Impact flag identifying the command line interface (CLI) wallet application 9c Large Effort estimation indicating TBD bug cli compatibility

Comments

@86chenjie
Copy link

using latest cli: https://github.com/bitshares/bitshares-core/releases/download/2.0.180823/BitShares-Core-2.0.180823-Windows-x64-cli-tools.zip

list_account_balances jeff-chen-1
throw err

0 exception: unspecified
Assert Exception: first_dot != second_dot:
    {"error":"Assert Exception: first_dot != second_dot: ","data":{"id":10,"jsonrpc":"2.0","error":{"code":1,"message":"Assert Exception: first_dot != second_dot: ","data":{"code":10,"name":"assert_exception","message":"Assert Exception","stack":[{"context":{"level":"error","file":"object_id.hpp","line":204,"method":"from_variant","hostname":"","thread_name":"th_a","timestamp":"2018-09-07T00:57:21"},"format":"first_dot != second_dot: ","data":{}},{"context":{"level":"warn","file":"object_id.hpp","line":210,"method":"from_variant","hostname":"","thread_name":"th_a","timestamp":"2018-09-07T00:57:21"},"format":"","data":{"var":"jeff-chen-1"}},{"context":{"level":"warn","file":"websocket_api.cpp","line":125,"method":"on_message","hostname":"","thread_name":"th_a","timestamp":"2018-09-07T00:57:21"},"format":"","data":{"call.method":"call","call.params":[2,"get_account_balances",["jeff-chen-1",[]]]}}]}}}}
    th_a  state.cpp:38 fc::rpc::state::handle_reply
@86chenjie
Copy link
Author

btw, i found blind tranfer only support BTS, other assets are not supported. Is this true?

@abitmore abitmore added cli bug 3d Bug Classification indicating the existing implementation does not match the intention of the design 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 6 CLI Impact flag identifying the command line interface (CLI) wallet application 9b Small Effort estimation indicating TBD labels Sep 7, 2018
@abitmore abitmore added 0 Question Notification that Issue has an open question. Please reference open question within Description bug 3d Bug Classification indicating the existing implementation does not match the intention of the design and removed 3d Bug Classification indicating the existing implementation does not match the intention of the design bug labels Sep 7, 2018
@abitmore
Copy link
Member

abitmore commented Sep 7, 2018

@86chenjie which API server (witness_node) did you connect the cli_wallet to when encountered this error?

I think this error only occurs when connecting a 2.0.180823 cli_wallet to an old witness_node. It's introduced by this code change: 21562e7#diff-eba6dcca79f28def3dea11f284600592R2819 . IMHO we need to revert the change, and add a TODO there to re-apply the change after next hard fork.

btw, i found blind tranfer only support BTS, other assets are not supported. Is this true?

False.

@abitmore abitmore added compatibility and removed 0 Question Notification that Issue has an open question. Please reference open question within Description labels Sep 7, 2018
@abitmore
Copy link
Member

abitmore commented Sep 7, 2018

@oxarbitrage we need to review all CLI changes done in #989 and related pull requests, to get rid of compatibility issues (read: cli_wallet can be connecting to an old witness_node):

  • need to be defensive, so still need to query with account IDs by now (need to convert to strings first otherwise won't compile);
  • add comments/TODOs so we will cleanup the code after next consensus upgrade (all nodes will be running new version after the upgrade is in effect);
  • be careful when working on refactor get_assets to accept id or name #1272 to avoid same issue.

@abitmore abitmore added 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 9c Large Effort estimation indicating TBD and removed 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 9b Small Effort estimation indicating TBD labels Sep 7, 2018
@86chenjie
Copy link
Author

86chenjie commented Sep 7, 2018

@abitmore thanks for your response

  1. cli_wallet.exe -s wss://ws.gdex.top
    this is the node i use.

  2. blind tranfer support other asset like GDEX.EOS ? i tried, err throw

transfer_to_blind jeff-chen GDEX.EOS [[user1,5]] true
1171421ms th_a       wallet.cpp:4413               transfer_to_blind    ] to_amounts: [["user1","5"]]
10 assert_exception: Assert Exception
!ec: websocket send failed: invalid state
    {"msg":"invalid state"}
    th_a  websocket.cpp:164 fc::http::detail::websocket_connection_impl<class std::shared_ptr<class websocketpp::connection<struct fc::http::detail::asio_tls_stub_log> > >::send_message

    {"from_account_id_or_name":"jeff-chen","asset_symbol":"GDEX.EOS","to_amounts":[["user1","5"]]}
    th_a  wallet.cpp:4488 graphene::wallet::wallet_api::transfer_to_blind
unlocked >>>

@abitmore
Copy link
Member

abitmore commented Sep 7, 2018

!ec: websocket send failed: invalid state

When you see this error, you need to quit cli_wallet and relaunch and reconnect to the API node.

@pmconrad
Copy link
Contributor

pmconrad commented Sep 9, 2018

blind tranfer support other asset like GDEX.EOS ? i tried, err throw

GDEX.EOS has the whitelist flag set. Assets with that flag cannot be transferred in stealth mode.

@oxarbitrage
Copy link
Member

the compatibility issue was solved at #1323 with a temporal code addition to the wallet involved calls until next hardfork, when we will know everybody is in the last version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 CLI Impact flag identifying the command line interface (CLI) wallet application 9c Large Effort estimation indicating TBD bug cli compatibility
Projects
None yet
Development

No branches or pull requests

4 participants