Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Boost version 1.69 #1557

Closed
2 of 5 tasks
jmjatlanta opened this issue Feb 5, 2019 · 6 comments
Closed
2 of 5 tasks

Support Boost version 1.69 #1557

jmjatlanta opened this issue Feb 5, 2019 · 6 comments
Assignees
@jmjatlanta
Milestone
3.1.0 - Feature R...

Comments

@jmjatlanta
Copy link
Contributor

jmjatlanta commented Feb 5, 2019 •
edited by ryanRfox
Loading

Boost 1.68 removed some headers. To compile with Boost 1.68 and above, changes will have to be made to bitshares-core.

Build Error Description
header boost/context/all.hpp cannot be found

Build Environment

  • Host OS: Ubuntu 18.10
  • Host Physical RAM 32GB
  • Source Branch/Tag: develop
  • OpenSSL Version: 1.1.0h
  • Boost Version: 1.68.0
  • C++ Compiler: g++

Steps To Reproduce
attempt to compile bitshares-core with Boost 1.68

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Fix build error
  • Update Documentation
    • Wiki
    • dev.bitshares.works
@jmjatlanta jmjatlanta self-assigned this Feb 5, 2019
@abitmore abitmore added this to the Future Feature Release milestone Feb 5, 2019
@jmjatlanta
Copy link
Contributor Author

This was already done. Thanks @nathanhourt

@abitmore
Copy link
Member

abitmore commented Feb 8, 2019

If boost 1.68 is supported we need to update README and wiki. By the way which commit(s) are for this issue?

@abitmore abitmore reopened this Feb 8, 2019
@nathanielhourt
Copy link
Contributor

@abitmore The most relevant to this issue's description is bitshares/bitshares-fc@2e0a03a but this one is more relevant to supporting newer versions of boost, as otherwise there were serious errors: 0da5d96

@nathanielhourt
Copy link
Contributor

Oh, and fwiw: I can build and sync with Boost 1.69 without issue

@pmconrad pmconrad added the 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added label Feb 10, 2019
@jmjatlanta jmjatlanta mentioned this issue Feb 15, 2019
Merged
@ryanRfox ryanRfox changed the title Support Boost version 1.68 Support Boost version 1.69 Feb 27, 2019
@ryanRfox
Copy link
Contributor

Changed the Issue title to match the intent of the PR.

@abitmore abitmore mentioned this issue Mar 13, 2019
Merged
@abitmore abitmore removed the 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added label Mar 13, 2019
@jmjatlanta
Copy link
Contributor Author

Fixed by several past commits plus #1648 for documentation updates.

@MichelSantos MichelSantos mentioned this issue Mar 19, 2019
Closed
@MichelSantos MichelSantos mentioned this issue May 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmjatlanta jmjatlanta

Labels
None yet
Projects
None yet
Milestone
3.1.0 - Feature Release
Development

No branches or pull requests
5 participants
@nathanielhourt @jmjatlanta @pmconrad @abitmore @ryanRfox