Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend static variant with "is_type" helper method #1769

Closed
3 of 18 tasks
crypto-ape opened this issue May 22, 2019 · 2 comments
Closed
3 of 18 tasks

extend static variant with "is_type" helper method #1769

crypto-ape opened this issue May 22, 2019 · 2 comments
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) code cleanup
Milestone
3.2.0 - Feature R...

Comments

@crypto-ape
Copy link
Contributor

crypto-ape commented May 22, 2019 •
edited
Loading

Hey Monkeys!

User Story

As the (ape) programmer I want (banana) comfort so that it is easier to read and write the code.

I would like to know whether the following code improvement would get accepted a priori.

I am considering replacing every occurrence of operation.which() == operation::tag<X>::value with operation.is_of_type<X>() or operation.is_type<X>().

This change would make the code a little bit easier to write and read. No functionality would be changed.

Impacts

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)
  • Code Quality

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation

Ape out!
@abitmore abitmore added this to the Future Feature Release milestone May 22, 2019
@abitmore abitmore added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) code cleanup good first issue labels May 22, 2019
@oxarbitrage
Copy link
Member

I agree with the proposed change.

This was referenced Jun 11, 2019
Merged
Merged
@oxarbitrage
Copy link
Member

closed by #1792 and bitshares/bitshares-fc#138 .

Thank you @crypto-ape

@pmconrad pmconrad mentioned this issue Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) code cleanup
Projects
None yet
Milestone
3.2.0 - Feature Release
Development

No branches or pull requests
3 participants
@abitmore @oxarbitrage @crypto-ape