From 1bbf05ab76e9152067b84726948dfe7e24f3c209 Mon Sep 17 00:00:00 2001 From: abitmore Date: Wed, 21 Apr 2021 13:27:55 +0000 Subject: [PATCH 01/12] Find 2 different ports in cli_test for rpc and p2p --- tests/cli/main.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/cli/main.cpp b/tests/cli/main.cpp index 58fba86a05..df4347dc9c 100644 --- a/tests/cli/main.cpp +++ b/tests/cli/main.cpp @@ -108,7 +108,14 @@ std::shared_ptr start_application(fc::temp_directory auto sharable_cfg = std::make_shared(); auto& cfg = *sharable_cfg; server_port_number = fc::network::get_available_port(); + auto p2p_port = server_port_number; + for( size_t i = 0; i < 10 && p2p_port == server_port_number; ++i ) + { + p2p_port = fc::network::get_available_port(); + } + BOOST_REQUIRE( p2p_port != server_port_number ); fc::set_option( cfg, "rpc-endpoint", string("127.0.0.1:") + std::to_string(server_port_number) ); + fc::set_option( cfg, "p2p-endpoint", string("0.0.0.0:") + std::to_string(p2p_port) ); fc::set_option( cfg, "genesis-json", create_genesis_file(app_dir) ); fc::set_option( cfg, "seed-nodes", string("[]") ); fc::set_option( cfg, "custom-operations-start-block", uint32_t(1) ); From 84166cc4d376602adc4983648d7217afec5256f9 Mon Sep 17 00:00:00 2001 From: abitmore Date: Thu, 22 Apr 2021 21:58:47 +0000 Subject: [PATCH 02/12] Remove an unnecessary header include --- tests/performance/genesis_allocation.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/performance/genesis_allocation.cpp b/tests/performance/genesis_allocation.cpp index f3c06fe4a8..7ec3029b77 100644 --- a/tests/performance/genesis_allocation.cpp +++ b/tests/performance/genesis_allocation.cpp @@ -28,8 +28,6 @@ #include -#include - #include extern uint32_t GRAPHENE_TESTING_GENESIS_TIMESTAMP; From d65c18e2de836a462fa2d4c60dfbc5708c976ab1 Mon Sep 17 00:00:00 2001 From: Abit Date: Fri, 23 Apr 2021 00:39:53 +0200 Subject: [PATCH 03/12] Fix broken link --- tests/performance/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/performance/README.md b/tests/performance/README.md index 67b9b4afaf..b7b2d406e5 100644 --- a/tests/performance/README.md +++ b/tests/performance/README.md @@ -6,7 +6,8 @@ of our current implementation. The subject was talked about in detail at BitFest Amsterdam, Sep 22, 2018. The original description of the 100,000 transactions per second test can be -found at https://bitshares.org/blog/2015/06/08/measuring-performance/ . +found at +https://web.archive.org/web/20181111215859/https://bitshares.org/blog/2015/06/08/measuring-performance/ . Prepare ------- From 9dd8d643d8d55ce5c0dce170dc2c80b0d64e9ff7 Mon Sep 17 00:00:00 2001 From: abitmore Date: Sat, 24 Apr 2021 10:01:10 +0000 Subject: [PATCH 04/12] Restore default logger of network module to "p2p" --- libraries/net/node.cpp | 14 -------------- libraries/net/node_impl.hxx | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libraries/net/node.cpp b/libraries/net/node.cpp index 51bffa0880..03fa07b940 100644 --- a/libraries/net/node.cpp +++ b/libraries/net/node.cpp @@ -91,13 +91,6 @@ #include "node_impl.hxx" -//#define ENABLE_DEBUG_ULOGS - -#ifdef DEFAULT_LOGGER -# undef DEFAULT_LOGGER -#endif -#define DEFAULT_LOGGER "p2p" - #define INVOCATION_COUNTER(name) \ static size_t total_ ## name ## _counter = 0; \ static size_t active_ ## name ## _counter = 0; \ @@ -118,13 +111,6 @@ } \ } invocation_logger(&total_ ## name ## _counter, &active_ ## name ## _counter) -//log these messages even at warn level when operating on the test network -#ifdef GRAPHENE_TEST_NETWORK -#define testnetlog wlog -#else -#define testnetlog(...) do {} while (0) -#endif - namespace graphene { namespace net { namespace detail { void blockchain_tied_message_cache::block_accepted() diff --git a/libraries/net/node_impl.hxx b/libraries/net/node_impl.hxx index 303c3b65a1..2b395223c8 100644 --- a/libraries/net/node_impl.hxx +++ b/libraries/net/node_impl.hxx @@ -16,6 +16,20 @@ namespace bmi = boost::multi_index; #define P2P_IN_DEDICATED_THREAD +//#define ENABLE_DEBUG_ULOGS + +#ifdef DEFAULT_LOGGER +# undef DEFAULT_LOGGER +#endif +#define DEFAULT_LOGGER "p2p" + +//log these messages even at warn level when operating on the test network +#ifdef GRAPHENE_TEST_NETWORK +#define testnetlog wlog +#else +#define testnetlog(...) do {} while (0) +#endif + /******* * A class to wrap std::unordered_set for multithreading */ From bd2f34d4e137747b7a362d63bc95a082189a6674 Mon Sep 17 00:00:00 2001 From: hammadsherwani <83015346+hammadsherwani@users.noreply.github.com> Date: Sat, 24 Apr 2021 16:37:59 +0500 Subject: [PATCH 05/12] Update seed-nodes.txt Placing node at 9th place, "seed.bitshares.rocks:1776", // bitshares (USA) --- libraries/egenesis/seed-nodes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/egenesis/seed-nodes.txt b/libraries/egenesis/seed-nodes.txt index 4816708ad3..9ce6e0549c 100644 --- a/libraries/egenesis/seed-nodes.txt +++ b/libraries/egenesis/seed-nodes.txt @@ -6,4 +6,5 @@ "seed2.xbts.io:1776", // xbts.io (Germany) "seed1.bitshares.im:1776", // clone (USA) "seed.bitshares.org:666", // bitshares.org (France) +"seed.bitshares.rocks:1776", // bitshares (USA) "seeds.btsnodes.com:1776", // Community From aef44330a5fc3162740d8a5eabaf83c464b3447e Mon Sep 17 00:00:00 2001 From: Abit Date: Sat, 24 Apr 2021 13:43:17 +0200 Subject: [PATCH 06/12] Update comment --- libraries/egenesis/seed-nodes.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/egenesis/seed-nodes.txt b/libraries/egenesis/seed-nodes.txt index 9ce6e0549c..192b93475d 100644 --- a/libraries/egenesis/seed-nodes.txt +++ b/libraries/egenesis/seed-nodes.txt @@ -6,5 +6,5 @@ "seed2.xbts.io:1776", // xbts.io (Germany) "seed1.bitshares.im:1776", // clone (USA) "seed.bitshares.org:666", // bitshares.org (France) -"seed.bitshares.rocks:1776", // bitshares (USA) +"seed.bitshares.rocks:1776", // bitshares.rocks (USA) "seeds.btsnodes.com:1776", // Community From 11da12d767fe43db8f2a96e489075b109d2a1f01 Mon Sep 17 00:00:00 2001 From: Abit Date: Sun, 25 Apr 2021 02:38:11 +0200 Subject: [PATCH 07/12] Remove unused code --- libraries/net/node.cpp | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/libraries/net/node.cpp b/libraries/net/node.cpp index 03fa07b940..034779a8c4 100644 --- a/libraries/net/node.cpp +++ b/libraries/net/node.cpp @@ -91,26 +91,6 @@ #include "node_impl.hxx" -#define INVOCATION_COUNTER(name) \ - static size_t total_ ## name ## _counter = 0; \ - static size_t active_ ## name ## _counter = 0; \ - struct name ## _invocation_logger { \ - size_t *total; \ - size_t *active; \ - name ## _invocation_logger(size_t *total, size_t *active) : \ - total(total), active(active) \ - { \ - ++*total; \ - ++*active; \ - dlog("NEWDEBUG: Entering " #name ", now ${total} total calls, ${active} active calls", ("total", *total)("active", *active)); \ - } \ - ~name ## _invocation_logger() \ - { \ - --*active; \ - dlog("NEWDEBUG: Leaving " #name ", now ${total} total calls, ${active} active calls", ("total", *total)("active", *active)); \ - } \ - } invocation_logger(&total_ ## name ## _counter, &active_ ## name ## _counter) - namespace graphene { namespace net { namespace detail { void blockchain_tied_message_cache::block_accepted() From c9a96a8d01075184730f54098e5f65075a1bced2 Mon Sep 17 00:00:00 2001 From: abitmore Date: Mon, 26 Apr 2021 19:19:59 +0000 Subject: [PATCH 08/12] Bump FC to include the contributors update --- libraries/fc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/fc b/libraries/fc index 0954033fa5..02b7593a96 160000 --- a/libraries/fc +++ b/libraries/fc @@ -1 +1 @@ -Subproject commit 0954033fa5f2991352a922114fdf4a0667ec5a18 +Subproject commit 02b7593a96b02d9966358c59d22f344d86fa9a19 From b1ceebc84285f323345f170a680730c972b90d83 Mon Sep 17 00:00:00 2001 From: abitmore Date: Mon, 26 Apr 2021 20:32:25 +0000 Subject: [PATCH 09/12] Update boost source code download link --- .github/workflows/build-and-test.win.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.win.yml b/.github/workflows/build-and-test.win.yml index 68bca8940d..e1fad2984e 100644 --- a/.github/workflows/build-and-test.win.yml +++ b/.github/workflows/build-and-test.win.yml @@ -30,7 +30,7 @@ jobs: - name: Download library sources if: steps.cache-libs.outputs.cache-hit != 'true' run: | - curl -LO https://dl.bintray.com/boostorg/release/${{ env.BOOST_DOTTED_VERSION }}/source/boost_${{ env.BOOST_VERSION }}.tar.bz2 + curl -LO https://boostorg.jfrog.io/artifactory/main/release/${{ env.BOOST_DOTTED_VERSION }}/source/boost_${{ env.BOOST_VERSION }}.tar.bz2 curl -LO https://curl.haxx.se/download/curl-${{ env.CURL_VERSION }}.tar.bz2 curl -LO https://www.openssl.org/source/openssl-${{ env.OPENSSL_VERSION }}.tar.gz curl -LO https://zlib.net/zlib-${{ env.ZLIB_VERSION }}.tar.gz From 22af85cd4320f0fa307b15ff2fa02704f92935ea Mon Sep 17 00:00:00 2001 From: abitmore Date: Tue, 27 Apr 2021 11:07:19 +0000 Subject: [PATCH 10/12] Bump docs version --- docs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs b/docs index 0a09ebbfd7..aa766179d5 160000 --- a/docs +++ b/docs @@ -1 +1 @@ -Subproject commit 0a09ebbfd71c6e80bb8cf87dbd1794f425a1d300 +Subproject commit aa766179d5a206581e7507c365646ec24d23b638 From a2c2dfde78deb499ad78c9f502d04dfe79e9d700 Mon Sep 17 00:00:00 2001 From: abitmore Date: Tue, 27 Apr 2021 11:09:39 +0000 Subject: [PATCH 11/12] Update version in Doxyfile --- Doxyfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doxyfile b/Doxyfile index 3d8c8770a5..7467d92fa0 100644 --- a/Doxyfile +++ b/Doxyfile @@ -38,7 +38,7 @@ PROJECT_NAME = "BitShares-Core" # could be handy for archiving the generated documentation or if some version # control system is used. -PROJECT_NUMBER = "5.1.0" +PROJECT_NUMBER = "5.2.0" # Using the PROJECT_BRIEF tag one can provide an optional one line description # for a project that appears at the top of each page and should give viewer a From 55a528f6f48810306d5c2eebb00edab6a7d0353b Mon Sep 17 00:00:00 2001 From: abitmore Date: Tue, 27 Apr 2021 11:12:20 +0000 Subject: [PATCH 12/12] Update contributors --- CONTRIBUTORS.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt index 6a0a654748..356e2d8af0 100644 --- a/CONTRIBUTORS.txt +++ b/CONTRIBUTORS.txt @@ -75,6 +75,7 @@ Troglodactyl VoR0220 alt bitcube +hammadsherwani <83015346+hammadsherwani@users.noreply.github.com> lafona liondani lososeg