Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio does not show all assets, nor count in all open orders #3224

Closed
abitmore opened this issue Feb 28, 2020 · 4 comments
Closed

Portfolio does not show all assets, nor count in all open orders #3224

abitmore opened this issue Feb 28, 2020 · 4 comments

Comments

@abitmore
Copy link
Member

abitmore commented Feb 28, 2020

Describe the bug
See https://wallet.bitshares.org/#/account/president-jiang , as of writing, the page shows "Total of 93 assets". According to https://cryptofresh.com/u/president-jiang https://blocksights.info/#/accounts/1.2.539130, the account holds balances of more than 100 assets (although data on CF could be stale).

Expected behavior
The page should show all assets an account owns.

Additional context
This is caused by a change on the get_full_accounts API introduced in BitShares Core 3.2.0 release.
See bitshares/bitshares-core#1808:

The get_full_accounts API

  • will return different fields: two fields (withdraws and htlcs) have been removed and are replaced by four fields (withdraws_from, withdraws_to, htlcs_from, htlcs_to);
  • lists returned by the API are limited to certain sizes (configurable by node operator), a more_data_available field is added to indicate what lists are incomplete due to the limit. Clients need to call other APIs to query for next pages of data.
@abitmore
Copy link
Member Author

abitmore commented Mar 1, 2020

The same issue applies to open orders. If a user has more than 100 open orders, the UI doesn't show all of them, also the data in "in orders" column of portfolio page would be incorrect.

@abitmore abitmore changed the title Portfolio does not show all assets Portfolio does not show all assets, nor count in all open orders Mar 1, 2020
@sschiessl-bcp
Copy link
Contributor

Reference #3248

@sschiessl-bcp
Copy link
Contributor

bitshares-js provides a new method for this, currently only supporting "balance". This needs to be extended to open orders to fix #3248 and both implemented in the UI

@ihorml
Copy link
Contributor

ihorml commented Feb 2, 2023

@sschiessl-bcp I've tested the provided url - https://wallet.bitshares.org/#/account/president-jiang and it currently have the possibility to return all the balances. Please verify it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants