From 1721592ae1b0f98b980a4aea6899ff283b627f52 Mon Sep 17 00:00:00 2001 From: "Benjamin Scholtysik (Reimold)" Date: Wed, 13 Dec 2017 14:38:49 -0800 Subject: [PATCH 1/2] Bump the version to 5.1.1 --- Documentation/Guides/Changelog.md | 5 +++++ Documentation/Guides/Installation & Setup.md | 8 ++++---- Documentation/HockeySDK/.jazzy.yaml | 2 +- HockeySDK-Source.podspec | 4 ++-- HockeySDK.podspec | 2 +- README.md | 10 +++++----- Support/HockeySDKBase.xcconfig | 4 ++-- 7 files changed, 20 insertions(+), 15 deletions(-) diff --git a/Documentation/Guides/Changelog.md b/Documentation/Guides/Changelog.md index 57b675a9..8b73c62c 100644 --- a/Documentation/Guides/Changelog.md +++ b/Documentation/Guides/Changelog.md @@ -1,3 +1,8 @@ +## 5.1.1 + +- [BUGFIX] Fixes a critical bug that would cause apps to freeze when calling `trackEvent` in UIApplicationDelegate callbacks. [#492](https://github.com/bitstadium/HockeySDK-iOS/pull/493) +- [BUGFIX] Fix a critical bug in the crashonly variant of the SDK. [#49](https://github.com/bitstadium/HockeySDK-iOS/pull/494) + ## 5.1.0 - [FEATURE] Add Turkish localization thanks to [Ozgur](https://github.com/ozgur).[#478](https://github.com/bitstadium/HockeySDK-iOS/pull/478) diff --git a/Documentation/Guides/Installation & Setup.md b/Documentation/Guides/Installation & Setup.md index ef92c990..63543bc6 100644 --- a/Documentation/Guides/Installation & Setup.md +++ b/Documentation/Guides/Installation & Setup.md @@ -3,9 +3,9 @@ [![Version](http://cocoapod-badges.herokuapp.com/v/HockeySDK/badge.png)](http://cocoadocs.org/docsets/HockeySDK) [![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net) -## Version 5.1.0 +## Version 5.1.1 -- [Changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.0/docs/docs/Changelog.html) +- [Changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.1/docs/docs/Changelog.html) **NOTE** If your are using the binary integration of our SDK, make sure that the `HockeySDKResources.bundle` inside the `HockeySDK.embeddedframework`-folder has been added to your application. @@ -821,7 +821,7 @@ To check if data is send properly to HockeyApp and also see some additional SDK ## 4. Documentation -Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/5.1.0/index.html). +Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/5.1.1/index.html). ## 5.Troubleshooting @@ -835,7 +835,7 @@ Our documentation can be found on [HockeyApp](http://hockeyapp.net/help/sdk/ios/ Make sure none of the following files are copied into your app bundle, check under app target, `Build Phases`, `Copy Bundle Resources` or in the `.app` bundle after building: - `HockeySDK.framework` (except if you build a dynamic framework version of the SDK yourself!) - - `de.bitstadium.HockeySDK-iOS-5.1.0.docset` + - `de.bitstadium.HockeySDK-iOS-5.1.1.docset` ### Features are not working as expected diff --git a/Documentation/HockeySDK/.jazzy.yaml b/Documentation/HockeySDK/.jazzy.yaml index 55f6973c..bdd1afd8 100644 --- a/Documentation/HockeySDK/.jazzy.yaml +++ b/Documentation/HockeySDK/.jazzy.yaml @@ -5,7 +5,7 @@ sdk: iphonesimulator theme: ../Themes/apple module: HockeySDK -module_version: 5.1.0 +module_version: 5.1.1 author: Microsoft Corp author_url: https://www.microsoft.com diff --git a/HockeySDK-Source.podspec b/HockeySDK-Source.podspec index 4fac8aa1..5101e37f 100644 --- a/HockeySDK-Source.podspec +++ b/HockeySDK-Source.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'HockeySDK-Source' - s.version = '5.1.0' + s.version = '5.1.1' s.summary = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.' s.description = <<-DESC @@ -25,7 +25,7 @@ Pod::Spec.new do |s| s.frameworks = 'CoreGraphics', 'CoreTelephony', 'CoreText', 'MobileCoreServices', 'Photos', 'QuartzCore', 'QuickLook', 'Security', 'SystemConfiguration', 'UIKit' s.libraries = 'c++', 'z' s.vendored_frameworks = 'Vendor/CrashReporter.framework' - s.pod_target_xcconfig = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"106\\"" BITHOCKEY_C_BUILD="\\"106\\""} } + s.pod_target_xcconfig = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_C_VERSION="\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"107\\"" BITHOCKEY_C_BUILD="\\"107\\""} } s.resource_bundle = { 'HockeySDKResources' => ['Resources/*.png', 'Resources/*.lproj'] } s.preserve_paths = 'Resources', 'Support' s.private_header_files = 'Classes/*Private.h' diff --git a/HockeySDK.podspec b/HockeySDK.podspec index 3649e099..8a7c6d7f 100644 --- a/HockeySDK.podspec +++ b/HockeySDK.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'HockeySDK' - s.version = '5.1.0' + s.version = '5.1.1' s.summary = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.' s.description = <<-DESC diff --git a/README.md b/README.md index 32e1466b..ae4e37ba 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ [![Version](http://cocoapod-badges.herokuapp.com/v/HockeySDK/badge.png)](http://cocoadocs.org/docsets/HockeySDK) [![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net) -## Version 5.1.0 +## Version 5.1.1 HockeySDK-iOS implements support for using HockeyApp in your iOS applications. @@ -23,13 +23,13 @@ The following features are currently supported: ## 1. Setup -It is super easy to use HockeyApp in your iOS app. Have a look at our [documentation](https://www.hockeyapp.net/help/sdk/ios/5.1.0/index.html) and onboard your app within minutes. +It is super easy to use HockeyApp in your iOS app. Have a look at our [documentation](https://www.hockeyapp.net/help/sdk/ios/5.1.1/index.html) and onboard your app within minutes. ## 2. Documentation -Please visit [our landing page](https://www.hockeyapp.net/help/sdk/ios/5.1.0/index.html) as a starting point for all of our documentation. +Please visit [our landing page](https://www.hockeyapp.net/help/sdk/ios/5.1.1/index.html) as a starting point for all of our documentation. -Please check out our [changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.0/changelog.html), as well as our [troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.0/installation--setup.html#troubleshooting). +Please check out our [changelog](http://www.hockeyapp.net/help/sdk/ios/5.1.1/changelog.html), as well as our [troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.1/installation--setup.html#troubleshooting). ## 3. Contributing @@ -53,4 +53,4 @@ You must sign a [Contributor License Agreement](https://cla.microsoft.com/) befo ## 4. Contact -If you have further questions or are running into trouble that cannot be resolved by any of the steps [in our troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.0/installation--setup.html#troubleshooting), feel free to open an issue here, contact us at [support@hockeyapp.net](mailto:support@hockeyapp.net) or join our [Slack](https://slack.hockeyapp.net). +If you have further questions or are running into trouble that cannot be resolved by any of the steps [in our troubleshooting section](https://www.hockeyapp.net/help/sdk/ios/5.1.1/installation--setup.html#troubleshooting), feel free to open an issue here, contact us at [support@hockeyapp.net](mailto:support@hockeyapp.net) or join our [Slack](https://slack.hockeyapp.net). diff --git a/Support/HockeySDKBase.xcconfig b/Support/HockeySDKBase.xcconfig index f1ba785c..d5eea602 100644 --- a/Support/HockeySDKBase.xcconfig +++ b/Support/HockeySDKBase.xcconfig @@ -1,5 +1,5 @@ -BUILD_NUMBER = 106 -VERSION_STRING = 5.1.0 +BUILD_NUMBER = 107 +VERSION_STRING = 5.1.1 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(HOCKEYSDK_GCC_PREPROCESSOR_DEFINITIONS) HOCKEYSDK_CONFIGURATION_$(CONFIGURATION) BITHOCKEY_VERSION="@\""$(VERSION_STRING)"\"" BITHOCKEY_BUILD="@\""$(BUILD_NUMBER)"\"" BITHOCKEY_C_VERSION="\""$(VERSION_STRING)"\"" BITHOCKEY_C_BUILD="\""$(BUILD_NUMBER)"\"" BIT_ARM_ARCHS = armv7 armv7s arm64 BIT_SIM_ARCHS = x86_64 i386 From 34f449206878144d97b6b57f44e7326581a220dd Mon Sep 17 00:00:00 2001 From: Murat Baysangurov Date: Thu, 14 Dec 2017 17:05:34 +0300 Subject: [PATCH 2/2] Fix feedback window in landscape mode --- Classes/BITFeedbackComposeViewController.m | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/Classes/BITFeedbackComposeViewController.m b/Classes/BITFeedbackComposeViewController.m index a2fc85de..de7274fb 100644 --- a/Classes/BITFeedbackComposeViewController.m +++ b/Classes/BITFeedbackComposeViewController.m @@ -155,11 +155,7 @@ - (void)keyboardWasShown:(NSNotification*)aNotification { CGRect frame = CGRectMake(0, 0, self.view.frame.size.width, self.view.frame.size.height); if (UI_USER_INTERFACE_IDIOM() != UIUserInterfaceIdiomPad) { - if (isPortraitOrientation) { - frame.size.height -= kbSize.height; - } else { - frame.size.height -= kbSize.width; - } + frame.size.height -= kbSize.height; } else { CGSize windowSize = [[UIScreen mainScreen] bounds].size; CGFloat windowHeight = windowSize.height - 20; @@ -168,20 +164,19 @@ - (void)keyboardWasShown:(NSNotification*)aNotification { if (isPortraitOrientation) { frame.size.height = windowHeight - navBarHeight - kbSize.height; } else { - windowHeight = windowSize.width - 20; + windowHeight = windowSize.height - 20; CGFloat modalGap = 0.0; - if (windowHeight - kbSize.width < self.view.bounds.size.height) { + if (windowHeight - kbSize.height < self.view.bounds.size.height) { modalGap = 30; } else { modalGap = (windowHeight - self.view.bounds.size.height) / 2; } - frame.size.height = windowSize.width - navBarHeight - modalGap - kbSize.width; + frame.size.height = windowSize.height - navBarHeight - modalGap - kbSize.height; } } [self.contentViewContainer setFrame:frame]; [self performSelector:@selector(refreshAttachmentScrollview) withObject:nil afterDelay:0.0]; - } - (void)keyboardWillBeHidden:(NSNotification*) __unused aNotification {