This repository has been archived by the owner on Jul 23, 2022. It is now read-only.
Added GenericName for app on Linux #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added desktop option for building the app for Linux, just so "GenericName" could be specified so it looks better on Linux ("Name" and "Type" there because they're required).
|
|
kspearrin
approved these changes
Apr 26, 2020
This was referenced Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "GenericName" field for Bitwarden's desktop option for Linux, so that its icon displays a useful subtitle in menus and taskbars (demonstrated in screenshots below).
Since the convention is a short descriptive label of what the app is, and other password managers like KeePassXC and Keeper use "Password Manager", I also used "Password Manager".
Pic 1. Example of what other apps look like In the KDE taskbar:
Pic 2. What Bitwarden looks like before change:
Pic 3. What Bitwarden looks like after change:
Pic 4. Bitwarden in KDE Application Launcher before change:
Pic 5. Bitwarden in KDE Application Launcher after change:
This brings its appearance/behaviour in line with other apps on Linux.
There shouldn't be any other unexpected changes to the app on Linux, since the generated Desktop Entry file is the same except the new "GenericName".
Pic 6. Desktop entry file before change:
Pic 7. Desktop entry file after change:
(built & tested on Kubuntu 18.04)