Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1785] Change ruby publish workflow to use api key method #629

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

michalchecinski
Copy link
Contributor

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • .github/workflows/publish-ruby.yml: Use gem push with rubygem API key instead of automated release steps.

Before you submit

  • Please add unit tests where it makes sense to do so

@michalchecinski michalchecinski requested a review from a team as a code owner February 23, 2024 15:44
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details3e5d2fb2-b994-46d1-a740-4dc182bcc532

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-ruby.yml: 117 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (27ec020) to head (3004838).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         171      171           
  Lines       10345    10345           
=======================================
  Hits         6145     6145           
  Misses       4200     4200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michalchecinski michalchecinski merged commit 676069a into main Feb 23, 2024
59 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1785-change-to-api-key-ruby-publish branch February 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants