Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7067] Remove unnecessary unwraps #682

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR replaces the unwraps found in the audit by proper error handling, I've also had a quick look through the rest of the code base and replaced a bunch of others as well.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 60.67%. Comparing base (596ce17) to head (d414ced).

Files Patch % Lines
crates/bitwarden/src/auth/login/password.rs 0.00% 7 Missing ⚠️
crates/bitwarden/src/auth/login/api_key.rs 0.00% 6 Missing ⚠️
crates/bitwarden/src/auth/login/auth_request.rs 0.00% 5 Missing ⚠️
...s/bitwarden/src/mobile/vault/client_attachments.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/mobile/vault/client_sends.rs 0.00% 2 Missing ⚠️
crates/bw/src/auth/login.rs 0.00% 2 Missing ⚠️
crates/bitwarden-crypto/src/rsa.rs 80.00% 1 Missing ⚠️
crates/bitwarden/src/vault/cipher/login.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   60.61%   60.67%   +0.05%     
==========================================
  Files         170      170              
  Lines       10387    10382       -5     
==========================================
+ Hits         6296     6299       +3     
+ Misses       4091     4083       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia requested a review from Hinton March 27, 2024 12:04
@dani-garcia dani-garcia merged commit 51a5140 into main Mar 28, 2024
68 checks passed
@dani-garcia dani-garcia deleted the ps/PM-7067-remove-unwraps branch March 28, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants