Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement make_register_tde_keys #684

Closed
wants to merge 1 commit into from
Closed

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add support in the SDK to create the keys necessary for the just in time user for TDE

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Logo
Checkmarx One – Scan Summary & Detailsd4541093-06de-4485-a66b-7d1c895bb33e

No New Or Fixed Issues Found

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 60.34%. Comparing base (27cf054) to head (eaef2ca).

Files Patch % Lines
crates/bitwarden/src/auth/tde.rs 0.00% 26 Missing ⚠️
crates/bitwarden-uniffi/src/auth/mod.rs 0.00% 13 Missing ⚠️
crates/bitwarden/src/auth/client_auth.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   60.61%   60.34%   -0.27%     
==========================================
  Files         170      171       +1     
  Lines       10387    10433      +46     
==========================================
  Hits         6296     6296              
- Misses       4091     4137      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia force-pushed the ps/PM-7071-make-tde-keys branch from 1231c37 to eaef2ca Compare March 27, 2024 18:27
@dani-garcia dani-garcia deleted the ps/PM-7071-make-tde-keys branch March 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant