Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7051] Implement make_register_tde_keys #685

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add support in the SDK to create the keys necessary for the just in time user for TDE

@dani-garcia dani-garcia changed the title Implement make_register_tde_keys [PM-7051] Implement make_register_tde_keys Mar 28, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

Logo
Checkmarx One – Scan Summary & Details8a06ae7f-249e-4d15-a36c-049fe4a9b7e6

No New Or Fixed Issues Found

@dani-garcia dani-garcia marked this pull request as ready for review March 28, 2024 10:47
@dani-garcia dani-garcia requested a review from Hinton March 28, 2024 10:47
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 60.41%. Comparing base (27cf054) to head (975e6c1).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden/src/auth/tde.rs 0.00% 24 Missing ⚠️
crates/bitwarden-uniffi/src/auth/mod.rs 0.00% 13 Missing ⚠️
crates/bitwarden/src/auth/client_auth.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
- Coverage   60.61%   60.41%   -0.20%     
==========================================
  Files         170      171       +1     
  Lines       10387    10426      +39     
==========================================
+ Hits         6296     6299       +3     
- Misses       4091     4127      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit 0ae0226 into main Mar 28, 2024
67 checks passed
@dani-garcia dani-garcia deleted the ps/PM-7051-make-tde-keys branch March 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants