-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5 Support w/ Cocoapods #456
Comments
Warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'Payment' to 'Hashable' by implementing 'hash(into:)' instead |
And warning: 'public' modifier is redundant for property declared in a public extension in file SKProduct+LocalizedPrice.swift |
any plan convert it to swift5 ? |
According to the swift converter (apart from the deprecations) you just need to update line 50 of PaymentsController.swift (and of course the Podspec) to move to swift 5:
I'm keen to stop having the swift runtime added to all my downloads. |
Thank you! |
Expected Results
No warning to convert SwiftyStoreKit.framework to Swift 5
Actual Results
Xcode created warnings to convert SwiftyStoreKit.framework to Swift 5
Steps to Reproduce
Build the cocoapod in Xcode 10.2
The text was updated successfully, but these errors were encountered: