Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 Support w/ Cocoapods #456

Closed
jlaws opened this issue Mar 26, 2019 · 6 comments
Closed

Swift 5 Support w/ Cocoapods #456

jlaws opened this issue Mar 26, 2019 · 6 comments

Comments

@jlaws
Copy link

jlaws commented Mar 26, 2019

Expected Results

No warning to convert SwiftyStoreKit.framework to Swift 5

Actual Results

Xcode created warnings to convert SwiftyStoreKit.framework to Swift 5

Steps to Reproduce

Build the cocoapod in Xcode 10.2

@marcellofiore
Copy link

Warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'Payment' to 'Hashable' by implementing 'hash(into:)' instead

@ghost
Copy link

ghost commented Apr 4, 2019

And warning:

'public' modifier is redundant for property declared in a public extension
Replace 'public ' with ''

in file SKProduct+LocalizedPrice.swift

@Mosaics
Copy link

Mosaics commented Apr 26, 2019

any plan convert it to swift5 ?

@acushway
Copy link

According to the swift converter (apart from the deprecations) you just need to update line 50 of PaymentsController.swift (and of course the Podspec) to move to swift 5:

return payments.firstIndex(of: payment)

I'm keen to stop having the swift runtime added to all my downloads.

@bizz84
Copy link
Owner

bizz84 commented Apr 30, 2019

Swift 5 is now supported as of version 0.15.0.

See #457.

@bizz84 bizz84 closed this as completed Apr 30, 2019
@jlaws
Copy link
Author

jlaws commented May 2, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants