-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create ES5 output for IE11 compatibility. #696
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run |
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 80
Branches ? 29
========================================
Hits ? 80
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, this should be fine to merge. I'm curious, does this change the bundle size?
I assume it will because it most like requires more code to do ES5 support. I don't have specific numbers though. Let me get them for you and I'll report back. |
* master: chore: update node-version and add bundlephobia checker chore(deps): bump actions/cache from 2.1.5 to 2.1.6 (bjerkio#638) chore: normalize package.json (bjerkio#687)
* master: chore: set version
* master: chore: remove .nvmrc chore: Add bundlewatch
I added |
To address #520. May not be the only IE11 issue to resolve, but it at least gets it to load without syntax issues.