Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create ES5 output for IE11 compatibility. #696

Merged
merged 5 commits into from
Sep 26, 2021

Conversation

pseudoramble
Copy link
Contributor

To address #520. May not be the only IE11 issue to resolve, but it at least gets it to load without syntax issues.

@update-docs
Copy link

update-docs bot commented Aug 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@41ba672). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main      #696   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        80           
  Branches        ?        29           
========================================
  Hits            ?        80           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ba672...8d03764. Read the comment docs.

Copy link
Member

@simenandre simenandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this should be fine to merge. I'm curious, does this change the bundle size?

@pseudoramble
Copy link
Contributor Author

I assume it will because it most like requires more code to do ES5 support. I don't have specific numbers though. Let me get them for you and I'll report back.

* master:
  chore: update node-version and add bundlephobia checker
  chore(deps): bump actions/cache from 2.1.5 to 2.1.6 (bjerkio#638)
  chore: normalize package.json (bjerkio#687)
* master:
  chore: remove .nvmrc
  chore: Add bundlewatch
@simenandre
Copy link
Member

simenandre commented Sep 26, 2021

I added bundlewatch and tested it here; ended up with 3.98KB. I think that is fine 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants