Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: migrate to react 18 #827

Merged
merged 2 commits into from
Jul 4, 2022
Merged

feat!: migrate to react 18 #827

merged 2 commits into from
Jul 4, 2022

Conversation

peterhueer94
Copy link
Contributor

  • Added PropsWithChildren (Thanks for the tipp @braaar )
  • Updated React-Packages to 18.1.0

@dependabot
chore(deps-dev): bump @types/node from 14.14.41 to 17.0.29
2b6a8d3 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.41 to 17.0.29.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@update-docs
Copy link

update-docs bot commented Apr 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

@peterhueer94 peterhueer94 mentioned this pull request Apr 28, 2022
Closed
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@9b70ccf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main      #827   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        80           
  Branches        ?        29           
========================================
  Hits            ?        80           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b70ccf...9297ba3. Read the comment docs.

@simenandre simenandre requested a review from braaar April 29, 2022 22:36
@flcarre
Copy link

flcarre commented Jun 30, 2022

what are we waiting for ?

@braaar
Copy link
Member

braaar commented Jul 4, 2022

Sorry for the delay folks.

@cobraz Are we ready to merge this? Any changes we need to make to the PR for release-please purposes?

@simenandre
Copy link
Member

Sorry for the delay folks.

@cobraz Are we ready to merge this? Any changes we need to make to the PR for release-please purposes?

I can change the title of the PR to make release-please happy :)

@simenandre simenandre changed the title React 18 migration feat!: Migrate to React 18 Jul 4, 2022
@simenandre simenandre changed the title feat!: Migrate to React 18 feat!: migrate to react 18 Jul 4, 2022
@simenandre simenandre merged commit 28e998a into bjerkio:main Jul 4, 2022
@bjerk-bot bjerk-bot mentioned this pull request Jul 4, 2022
Closed
@bjerk-bot bjerk-bot mentioned this pull request Jul 15, 2022
Merged
@dheardal
Copy link
Contributor

dheardal commented Jul 26, 2022 •
edited
Loading

Is React 17 now unsupported? (Looks like 16 still is supported though)

@simenandre
Copy link
Member

Is React 17 now unsupported? (Looks like 16 still is supported though)

Should still work :)

@dheardal
Copy link
Contributor

Not without --legacy-peer-deps. Was the support dropped on purpose or am I ok to submit a new PR to add it back in?

@simenandre
Copy link
Member

simenandre commented Jul 28, 2022 •
edited
Loading

We can do that, yes! 👍

I would appreciate it if you opened a pull request! 🙏

This was referenced Mar 21, 2023
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braaar braaar braaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterhueer94 @flcarre @braaar @simenandre @dheardal