Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bundlesize dependency #936

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

jamesdh
Copy link
Contributor

@jamesdh jamesdh commented Feb 7, 2023

It doesn't appear the bundlesize dependency was being used for anything. I'm guessing its functionality was superseded by bundlewatch. In any case, its dependency on brotli-size, and in turn its dependency on iltorb appears to be what was causing the build failure since iltorb provides native bindings, and node-gyp was blowing up trying to build them.

Unless there is a reason to keep bundlesize, I figured it'd be far easier to just remove it instead of going down the rabbit hole that is node-gyp.

@update-docs
Copy link

update-docs bot commented Feb 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

@simenandre simenandre changed the title Remove bundlesize dependency, fix build? fix: remove bundlesize dependency Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants