libtiled-java - Tiled editor parity #2207
Conversation
…o preserve layer order
There was a problem hiding this comment.
Those are some great updates! I've left a few comments, though I haven't touched Java since so long I may be wrong about some of them. In general it seems pretty much ready for merging. Thank you so much for working on this!
I noticed you've also made some updates to the DTD. Is that file still relevant now that we have an XSD that describes the format in much more detail?
| @@ -345,6 +356,9 @@ private MapObject readMapObject(Node t) throws Exception { | |||
|
|
|||
| MapObject obj = new MapObject(x, y, width, height, rotation); | |||
| obj.setShape(obj.getBounds()); | |||
| if (id != 0) { | |||
There was a problem hiding this comment.
I reckon the id defaults to 0 anyway, in which case this condition is not adding any value and should just be removed.
| @@ -501,6 +575,11 @@ private ObjectGroup unmarshalObjectGroup(Node t) throws Exception { | |||
| final int offsetY = getAttribute(t, "y", 0); | |||
| og.setOffset(offsetX, offsetY); | |||
|
|
|||
| final int locked = getAttribute(t, "locked", 0); | |||
| if (locked != 0) { | |||
There was a problem hiding this comment.
Please also remove this condition and just call og.setLocked(locked).
| } | ||
|
|
||
| final int locked = getAttribute(t, "locked", 0); | ||
| if (locked != 0) { |
There was a problem hiding this comment.
Just call g.setLocked(locked) if the result is the same.
|
@viitahenri Will you still get around to finishing this pull request? Maybe it would be an option to make the minimal changes needed so that this can be merged, even though there may not yet be 100% parity? (I'm not sure what's missing in that regard) |
|
@viitahenri Alright, I've just merged this as-is since @csueiras could use these changes. I did some small corrections on top in commit d3c3987, but kept the If either of you wants to help further update or fix this library, such help would be really appreciated! Thank you for these updates! |
I've been making modifications to the libtiled-java in order to use it for automated processing/modifying of Tiled maps.
It's very much based on my current needs, so the features added to reading&writing the map files are features I've noticed end up with differences (or missing data altogether) in the map files.
I'm opening this PR mostly in case someone else has a need to touch the map files programmatically while maintaining the same file structure (the goal is to have no changes if you just do read/write with the Java lib).
Hoping to get this clean enough to be mergeable in the future.