Imgui redundant vertex attributes in varying.def

[Seyedof]

Hi, on my way to port existing engine to bgfx, I noticed something in the bgfx's Imgui render backend shaders:

bgfx/examples/common/imgui/varying.def.sc

Line 2 in acedbf0

vec3 v_normal : NORMAL = vec3(0.0, 0.0, 1.0);

Why do you need NORMAL? shouldn't it be removed? since Imgui vertex format only needs POSITION, COLOR0, TEXCOORD0 and the existing bgfx imgui shaders also don't need/use the NORMAL attribute.

[bkaradzic]

At some point there was ImGui widget that could render cubemap, and normal is used there:
45a54db

varying.def.sc doesn't affect any shaders, it just defines semantics for varyings. So since v_normal is not used anywhere in shaders, it won't affect anything, and it could be removed.

[Seyedof]

Yeah thanks, as you said it is no more used perhaps better to remove it from varying.def as well to keep code clean.

[bkaradzic]

43296d6