Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json, added missing export types for module #465

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

james-nair
Copy link
Contributor

@james-nair james-nair commented May 26, 2023

Added missing type output. Resolved vscode error for not finding type declaration for react-d3-tree package

@hyper-dot
Copy link

Why it is not merged till today 😢

@bkrem bkrem changed the base branch from master to fix/exports-types-field January 2, 2024 20:53
@bkrem bkrem merged commit 8ab0909 into bkrem:fix/exports-types-field Jan 2, 2024
@bkrem
Copy link
Owner

bkrem commented Jan 2, 2024

Hey folks, sorry about this! I've had very little time to maintain this lib for the past year but tried to keep things moving on urgent fixes, this one clearly got away from me. Feel free to nudge as @hyper-dot has here on major annoyances like this.

I was under the impression that the existing root level types field was sufficient but clearly there was a gap in my TS dogfooding, presumably when using ES module resolution in VSCode as indicated.

Thank you for the original fix PR @JimmyNair 🙏 Will ping back here when published.

@bkrem
Copy link
Owner

bkrem commented Jan 2, 2024

Fixed in https://github.com/bkrem/react-d3-tree/releases/tag/v3.6.2

@transfer1992
Copy link

transfer1992 commented Jan 2, 2024

Hey! Subscribers of this PR may have received some emails about me posting some concerns, but I just have educated myself and all is good. Sorry for the mess. Thanks for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants