Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferPool is extremely slow under contention #169

Closed
vkrasnov opened this issue Nov 4, 2021 · 1 comment · Fixed by #170
Closed

BufferPool is extremely slow under contention #169

vkrasnov opened this issue Nov 4, 2021 · 1 comment · Fixed by #170

Comments

@vkrasnov
Copy link
Contributor

vkrasnov commented Nov 4, 2021

I am running a highly concurrent MySQL client and the Mutex contention in BufferPool leads to extreme slowdown.

I tried replacing the Mutex<Vec<_>> with crossbeam::queue::ArrayQueue and it led to a 4 fold performance improvement (in terms of QPS). I don't really see any downsides in using ArrayQueue even under low load, so if you would consider it I will be more than happy to open a pull request.

Thanks.

@blackbeam
Copy link
Owner

Thanks! Yeah, PRs are much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants