Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with clientcommands - LockedSlotKeeper assumes container doesn't change #324

Closed
Earthcomputer opened this issue Apr 21, 2023 · 9 comments

Comments

@Earthcomputer
Copy link

Hi, I've looked briefly into a crash reported to clientcommands here and I think there is an issue in LockedSlotKeeper where it implicity assumes the container doesn't change by storing some slot ids, although I didn't fully understand what's going on yet. Clientcommands changes the open container when a container GUI is opened here. I was wondering if you could provide some insight into what's going on?

To reproduce, install clientcommands and inventory profiles next, join a world, place some dirt in a chest, then type /cfinditem dirt into chat.

@blackd
Copy link
Owner

blackd commented Apr 22, 2023

Yeah LockedSlotsKeeper is a mess I'm trying to make my self clean for a long time.
It should detect if a GUI is open and stop doing any thing until it's closed. But my guess is it happens to fast to be detected.
The assumption is that i works on the normal player inventory which is available even if it's not open.

@FlameUser706
Copy link

FlameUser706 commented Apr 25, 2023

Oh my lord, the reason for the crashes was the version difference, updating libIPN and Inventory Profiles Next solved the issue
Edit: Welp, maybe not-

@blackd
Copy link
Owner

blackd commented Apr 25, 2023

Well I'm happy it's fixed 😁

I have the new version spam on startup for a reason 🤣

edit Well it sounded too good lol

@FlameUser706
Copy link

Yeaaaah, I was kinda afraid that it wasn't going to be easy... do you want to chat on Discord so we're not clogging Github?

@blackd
Copy link
Owner

blackd commented Apr 25, 2023

yeap

@FlameUser706
Copy link

Alright
FlameUser706#5060

@blackd
Copy link
Owner

blackd commented Apr 25, 2023

@blackd
Copy link
Owner

blackd commented Apr 26, 2023

Soo the cause was pinned down to.... drumroll...

the server being paper.

@blackd
Copy link
Owner

blackd commented Apr 26, 2023

"Fix/Workaround" will be available in the next release. However 1.19.3 is no longer supported and will not receive the fix.

@blackd blackd closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants