Fix: SFDP basic parameter table handling #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader and parameter table header
…and handle table versioning for the page size properly
…() and handle table versioning for the page size properly
dragonmux
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 30 30
Lines 1560 1568 +8
Branches 491 495 +4
=====================================
- Misses 1524 1531 +7
- Partials 36 37 +1
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the fix in BMD PR blackmagic-debug/blackmagic#1599 this PR addresses an oversight and failing in the SFDP implementation which made the tool mis-handle devices that follow old versions of the specification.
The practical upshot of the bug is that we'd use invalid (0-init) data past the end of the extracted basic parameters table to determine the page program size of the device, leading to problems in all downstream uses of this data.