Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of dependencies #26

Open
wleoncio opened this issue Jan 16, 2023 · 2 comments
Open

Reduce number of dependencies #26

wleoncio opened this issue Jan 16, 2023 · 2 comments

Comments

@wleoncio
Copy link

Eyeing a potential CRAN submission (or at least a welcome bloat-reduction), would you consider reducing the number of dependencies in your package 20+ is a lot, IMO)?

@blind-contours
Copy link
Owner

This package requires a lot of dependencies by it's nature - integrating trees as a data-adaptive parameter (pre, partykit etc.) with machine learning (sl3, ranger, and others) then all the data formatting and parallelization (furrr, data.table, purr, stringr, stats, dplyr etc.). I see a couple ways moving forward where I can clean some things up. 1. Move simulations out of the package, this knocks out 1-2 packages that are required and moves them to suggests, 2. Getting rid of the plotting functions that come default in the package would get rid of 3. Also making the readme less pretty with knit I could also get rid of that. I'll make these changes before the submission to CRAN. Also SL3 is being updated for CRAN submission and that should get rid of the misc. dependencies we need to install for that package (should be packaged in SL3).

@wleoncio wleoncio reopened this Jan 30, 2023
@wleoncio
Copy link
Author

wleoncio commented Jan 30, 2023

Thank you for the reply, I'm happy to see a plan for this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants