Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_webhook is wrong type #225

Closed
jasom opened this issue Aug 16, 2022 · 1 comment · Fixed by #226
Closed

from_webhook is wrong type #225

jasom opened this issue Aug 16, 2022 · 1 comment · Fixed by #226
Assignees
Milestone

Comments

@jasom
Copy link

jasom commented Aug 16, 2022

here from_webhook is set to true but per the mattermost V4 api from_webhook is of type String, so it should actually be set to "true". Yes this is stupid, but clients that parse the messages strictly (e.g. matterhorn, or anything else that uses the haskell mattermost api implementation), will throw an error when encountering the malformed message.

@harshilsharma63
Copy link
Contributor

Thanks for posting this @jasom . I'll update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants