Scalelite Recordings Metrics & BBB Exporter

[faust64]

Hi,

Deploying Scalelite and the BigBlueButton Exporter ( https://github.com/greenstatic/bigbluebutton-exporter/ ), I noticed that while that exporter reports the right values for recordings (published / unpublished / update / deleted) when querying my BigBlueButton servers API, it seems to be broken when querying Scalelite.

The counters for published / unpublished / update / deleted recordings are all equals to the same value, which is the count of published recordings.

AFAIU, the exporter would query for some getRecordings API call, passing an argument ("deleted", "published", ...), over there:
https://github.com/greenstatic/bigbluebutton-exporter/blob/master/bbb-exporter/collector.py#L202

The recording state being sent as a param, in getRecording API command:
https://github.com/greenstatic/bigbluebutton-exporter/blob/master/bbb-exporter/api_lib.py#L86

Now, AFAIU, Scalelite doesn't look for arguments in the getRecordings command:

scalelite/app/controllers/bigbluebutton_api_controller.rb

Line 278 in 5feb7cb

def get_recordings

Thus, when the exporter would query for getRecordings with different arguments, the same counter would be returned 4 times.

I think it could be fixed with something like this:
https://github.com/blindsidenetworks/scalelite/compare/master...Worteks:fix-recordings-metrics?expand=1

After a few tests, I think this works - at least, I only see my published records (don't have others, and can't really test delete stuff/testing against prod...). PR is on its way ...

[jfederico]

Yeah, I don't think that filter was ever implemented in SL. This could be an enhancement

[faust64]

I've ended up upgrading my setup, building my own API image, and bumping the recordings-importer/poller/... to 1.1-beta.4.
See #546

Looks like it works. Though I'm no ruby nor BBB expert ...

[git-lama]

closed by pr