Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only resolveFields when async yaml types are present #74

Open
jeremydw opened this issue Apr 28, 2021 · 0 comments
Open

Only resolveFields when async yaml types are present #74

jeremydw opened this issue Apr 28, 2021 · 0 comments
Assignees

Comments

@jeremydw
Copy link
Member

Resolve fields can be slow, so we don't want to do it unnecessarily.

  • When adding new yaml types, check whether a yaml type has an async constructor.
  • If it does, set a flag indicating we need to resolve fields.
  • On projects that don't have async constructors, skip resolving fields.
@jeremydw jeremydw self-assigned this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant