Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys with accent on physical keyboard does not autorepeat #1965

Open
2 of 3 tasks
l2dy opened this issue Feb 17, 2024 · 10 comments
Open
2 of 3 tasks

Keys with accent on physical keyboard does not autorepeat #1965

l2dy opened this issue Feb 17, 2024 · 10 comments
Labels
bug Bug that's either related to Blink Shell or prevents the user to use the app in normal conditions. RTT Ready to test on Test Flight

Comments

@l2dy
Copy link
Contributor

l2dy commented Feb 17, 2024

Checklist

Configuration

Blink version: commit df04676
iOS version: 17.3.1

Describe the bug

Key j autorepeats when it is held, but w does not.

Can be reproduced on iPad (10th generation) and the corresponding iOS simulator.

Originally reported at https://discord.com/channels/441939332442619905/1207979699159175188.

Simulator Screenshot - iPad (10th generation) - 2024-02-17

@l2dy l2dy added the bug Bug that's either related to Blink Shell or prevents the user to use the app in normal conditions. label Feb 17, 2024
@carloscabanero
Copy link
Member

carloscabanero commented Feb 27, 2024

Thanks. Reviewing... I couldn't replicate on device but I could on Simulator.

@maxiR8
Copy link

maxiR8 commented Sep 18, 2024

Have same issue on iPad Pro 2021 after updating to iPad OS 18. When using vim H,K,L keys don’t repeat

@weilingxyz
Copy link

weilingxyz commented Sep 21, 2024

Same issue here after updating to iPadOS 18.

@kotashiratsuka
Copy link

+1 Same Problem

@trafalco
Copy link

trafalco commented Sep 24, 2024

Have same issue on iPad Pro 2021 after updating to iPad OS 18. When using vim H,K,L keys don’t repeat

Same here.

@l2dy
Copy link
Contributor Author

l2dy commented Sep 24, 2024

Please refrain from posting +1 only comments. Use the 👍 reaction on OP instead.

@carloscabanero
Copy link
Member

Just a heads up, this is my next priority as the hw keyboard should always be stable.

@carloscabanero carloscabanero added the WIP Work In Progress label Sep 24, 2024
@carloscabanero
Copy link
Member

Testing a fix on 18.0.1 on TestFlight. Unfortunately it isn't nice, will see if it goes through and then figure out what to do with it.

@l2dy
Copy link
Contributor Author

l2dy commented Oct 3, 2024

Can confirm that TF build 18.0.1 fixes the issue on iPadOS 18.0. Will need latest source code to try in emulator.

Update: Fix also confirmed in emulator.

@carloscabanero
Copy link
Member

carloscabanero commented Oct 7, 2024

Ok, pushed the fix. Leaving here a few notes:

  • This fix uses unpublished APIs, but it is the fastest way to solve it in mostly all the devices.
  • I have tried to clean up things or rework things, but I am honestly tired of these kind of problems that do not get any visibility from Apple. Same with the sticky command keys, or the Software keyboard displays, etc... From now on, we have a section for these types of fixes when it makes sense.
  • I opened a Radar and feature request.
  • We will move to a new terminal, and all keyboard control will be back on the Swift side instead of our Hterm implementation. So I'm not going to waste one more second with this.

@carloscabanero carloscabanero added RTT Ready to test on Test Flight and removed WIP Work In Progress labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that's either related to Blink Shell or prevents the user to use the app in normal conditions. RTT Ready to test on Test Flight
Projects
None yet
Development

No branches or pull requests

6 participants