Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollup help needed] Add new@blitzjs/framework pkg with separate client & server bundles #928

Closed
flybayer opened this issue Jun 6, 2020 · 0 comments · Fixed by blitz-js/blitz#2039

Comments

@flybayer
Copy link
Member

flybayer commented Jun 6, 2020

What do you want and why?

Currently we have framework code scattered around various packages, mostly @blitzjs/core and @blitzjs/server. We want to consolidate this code into @blitzjs/framework and then remove @blitzjs/core.

We are currently using tsdx for these packages, but I don't think we can use it for framework. Because in addition to isomorphic code, framework will have server only code that should be bundled separately from the client code to ensure server code never ends up in a client bundle.

We also want deep imports so we can do something like this:

import something from '@blitzjs/framework/client'
import something from '@blitzjs/framework/server'

I'd love to have this sooner rather than later :)

Additional context: #798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment