Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples #184

Open
gleb-kun opened this issue Feb 10, 2024 · 1 comment
Open

Examples #184

gleb-kun opened this issue Feb 10, 2024 · 1 comment

Comments

@gleb-kun
Copy link

After the question (#183), I studied the examples. I could update them according to the current state of the library. However, I saw the latest commit by @citibeth with IMPORTANT NOTICE. Does it make sense to prepare a PR?
@slayoo
Copy link
Member

slayoo commented Feb 10, 2024

Thank you @gleb-kun!
The notice is very true and valid (thanks @citibeth!), yet I'd say that it is still worth to improve the repo contents in such cases.
PR would be very welcome.

One caveat is that we have lost any CI capabilities after Travis CI was discontinued, and we have not been able yet to create a GitHub Actions equivalent yet - help welcome! (this should include compiling the examples, so that the problem you discovered would be caught)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slayoo @gleb-kun