Reducing duplicate code in NodeControllerTests

block-core · Aug 16, 2020 · ac5e5f2 · ac5e5f2
1 parent f4b3c46
commit ac5e5f2
Showing 1 changed file with 37 additions and 41 deletions.
diff --git a/src/Tests/Blockcore.Tests/Controllers/NodeControllerTest.cs b/src/Tests/Blockcore.Tests/Controllers/NodeControllerTest.cs
@@ -7,6 +7,7 @@
 using Blockcore.Base;
 using Blockcore.Configuration;
 using Blockcore.Connection;
+using Blockcore.Consensus;
 using Blockcore.Controllers;
 using Blockcore.Controllers.Models;
 using Blockcore.Interfaces;
@@ -45,6 +46,7 @@ public class NodeControllerTest : LogsTestBase
         private readonly Mock<IPooledTransaction> pooledTransaction;
         private readonly Mock<IAsyncProvider> asyncProvider;
         private readonly Mock<ISelfEndpointTracker> selfEndpointTracker;
+        private readonly Mock<IConsensusManager> consensusManager;
 
         private NodeController controller;
 
@@ -68,7 +70,12 @@ public NodeControllerTest()
             this.pooledTransaction = new Mock<IPooledTransaction>();
             this.asyncProvider = new Mock<IAsyncProvider>();
             this.selfEndpointTracker = new Mock<ISelfEndpointTracker>();
+            this.consensusManager = new Mock<IConsensusManager>();
 
+            this.CreateNewController();
+        }
+
+        private void CreateNewController() {
             this.controller = new NodeController(
                 this.chainIndexer,
                 this.chainState.Object,
@@ -84,7 +91,8 @@ public NodeControllerTest()
                 this.getUnspentTransaction.Object,
                 this.networkDifficulty.Object,
                 this.pooledGetUnspentTransaction.Object,
-                this.pooledTransaction.Object);
+                this.pooledTransaction.Object,
+                this.consensusManager.Object);
         }
 
         [Fact]
@@ -126,10 +134,8 @@ public async Task GetRawTransactionAsync_TransactionCannotBeFound_ReturnsNullAsy
             this.blockStore.Setup(b => b.GetTransactionById(txId))
                 .Returns((Transaction)null)
                 .Verifiable();
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
 
             string txid = txId.ToString();
             bool verbose = false;
@@ -150,10 +156,9 @@ public async Task GetRawTransactionAsync_TransactionNotInPooledTransaction_Retur
             Transaction transaction = this.CreateTransaction();
             this.blockStore.Setup(b => b.GetTransactionById(txId))
                 .Returns(transaction);
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             bool verbose = false;
 
@@ -189,10 +194,9 @@ public async Task GetRawTransactionAsync_PooledTransactionServiceNotAvailable_Re
             Transaction transaction = this.CreateTransaction();
             this.blockStore.Setup(b => b.GetTransactionById(txId))
                 .Returns(transaction);
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             bool verbose = false;
 
@@ -210,10 +214,9 @@ public async Task GetRawTransactionAsync_PooledTransactionAndBlockStoreServiceNo
             this.blockStore.Setup(f => f.GetTransactionById(txId))
                 .Returns((Transaction)null)
                 .Verifiable();
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             bool verbose = false;
 
@@ -231,10 +234,7 @@ public void DecodeRawTransaction_ReturnsTransaction()
                 .ReturnsAsync((Transaction)null);
             Transaction transaction = this.CreateTransaction();
 
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+            this.CreateNewController();
 
             var json = (JsonResult)this.controller.DecodeRawTransaction(new DecodeRawTransactionModel() { RawHex = transaction.ToHex() });
             var resultModel = (TransactionVerboseModel)json.Value;
@@ -403,11 +403,11 @@ public async Task GetTxOutAsync_NotIncludeInMempool_UnspentTransactionNotFound_R
         public async Task GetTxOutAsync_NotIncludeInMempool_GetUnspentTransactionNotAvailable_ReturnsNullAsync()
         {
             var txId = new uint256(1243124);
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
+
             uint vout = 0;
             bool includeMemPool = false;
 
@@ -423,10 +423,9 @@ public async Task GetTxOutAsync_IncludeMempool_UnspentTransactionNotFound_Return
             this.pooledGetUnspentTransaction.Setup(s => s.GetUnspentTransactionAsync(new OutPoint(txId, 0)))
                 .ReturnsAsync((UnspentOutput)null)
                 .Verifiable();
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             uint vout = 0;
             bool includeMemPool = true;
@@ -441,10 +440,9 @@ public async Task GetTxOutAsync_IncludeMempool_UnspentTransactionNotFound_Return
         public async Task GetTxOutAsync_IncludeMempool_PooledGetUnspentTransactionNotAvailable_UnspentTransactionNotFound_ReturnsNullAsync()
         {
             var txId = new uint256(1243124);
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             uint vout = 0;
             bool includeMemPool = true;
@@ -463,10 +461,9 @@ public async Task GetTxOutAsync_NotIncludeInMempool_UnspentTransactionFound_Retu
             this.getUnspentTransaction.Setup(s => s.GetUnspentTransactionAsync(new OutPoint(txId, 0)))
                 .ReturnsAsync(unspentOutputs)
                 .Verifiable();
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             uint vout = 0;
             bool includeMemPool = false;
@@ -491,10 +488,9 @@ public async Task GetTxOutAsync_IncludeInMempool_UnspentTransactionFound_Returns
             this.pooledGetUnspentTransaction.Setup(s => s.GetUnspentTransactionAsync(new OutPoint(txId, 0)))
                 .ReturnsAsync(unspentOutputs)
                 .Verifiable();
-            this.controller = new NodeController(this.chainIndexer, this.chainState.Object,
-                this.connectionManager.Object, this.dateTimeProvider.Object, this.fullNode.Object,
-                this.LoggerFactory.Object, this.nodeSettings, this.network, this.asyncProvider.Object, this.selfEndpointTracker.Object, this.blockStore.Object, this.getUnspentTransaction.Object,
-                this.networkDifficulty.Object, this.pooledGetUnspentTransaction.Object, this.pooledTransaction.Object);
+
+            this.CreateNewController();
+
             string txid = txId.ToString();
             uint vout = 0;
             bool includeMemPool = true;