Remove all warnings from the solution (#243)

* delete ruleset and migrate to edditorconfig

* Fix more warnings

* Fix many warnings

* Fix warnings on UI elements

* From now on treat warnings as errors

* fix warning

* Fix rocks db proj reference name

* Fix persistance to separate pow and pow

* Fix unit tests

src/.editorconfig

@@ -38,5 +38,154 @@ dotnet_naming_style.end_with_async.capitalization  = pascal_case
 # SA1401: Fields should be private
 dotnet_diagnostic.SA1401.severity = none
 
+# comments related
+dotnet_diagnostic.CS1591.severity                                 = none
+dotnet_diagnostic.CS1574.severity                                 = none
+dotnet_diagnostic.CS1584.severity                                 = none
+dotnet_diagnostic.CS1723.severity                                 = none
+dotnet_diagnostic.CS1570.severity                                 = none
+dotnet_diagnostic.CS1571.severity                                 = none
+dotnet_diagnostic.CS1572.severity                                 = none
+dotnet_diagnostic.CS1570.severity                                 = none
+dotnet_diagnostic.CS1587.severity                                 = none
+dotnet_diagnostic.CS1580.severity                                 = none
+dotnet_diagnostic.CSxxxx.severity                                 = none
+
+# migrated from rulset
+
+
+dotnet_diagnostic.CA1001.severity = warning
+dotnet_diagnostic.CA1009.severity = warning
+dotnet_diagnostic.CA1016.severity = warning
+dotnet_diagnostic.CA1033.severity = warning
+dotnet_diagnostic.CA1049.severity = warning
+dotnet_diagnostic.CA1060.severity = warning
+dotnet_diagnostic.CA1061.severity = warning
+dotnet_diagnostic.CA1063.severity = warning
+dotnet_diagnostic.CA1065.severity = warning
+dotnet_diagnostic.CA1301.severity = warning
+dotnet_diagnostic.CA1400.severity = warning
+dotnet_diagnostic.CA1401.severity = warning
+dotnet_diagnostic.CA1403.severity = warning
+dotnet_diagnostic.CA1404.severity = warning
+dotnet_diagnostic.CA1405.severity = warning
+dotnet_diagnostic.CA1410.severity = warning
+dotnet_diagnostic.CA1415.severity = warning
+dotnet_diagnostic.CA1821.severity = warning
+dotnet_diagnostic.CA1900.severity = warning
+dotnet_diagnostic.CA1901.severity = warning
+dotnet_diagnostic.CA2002.severity = warning
+dotnet_diagnostic.CA2100.severity = warning
+dotnet_diagnostic.CA2101.severity = warning
+dotnet_diagnostic.CA2108.severity = warning
+dotnet_diagnostic.CA2111.severity = warning
+dotnet_diagnostic.CA2112.severity = warning
+dotnet_diagnostic.CA2114.severity = warning
+dotnet_diagnostic.CA2116.severity = warning
+dotnet_diagnostic.CA2117.severity = warning
+dotnet_diagnostic.CA2122.severity = warning
+dotnet_diagnostic.CA2123.severity = warning
+dotnet_diagnostic.CA2124.severity = warning
+dotnet_diagnostic.CA2126.severity = warning
+dotnet_diagnostic.CA2131.severity = warning
+dotnet_diagnostic.CA2132.severity = warning
+dotnet_diagnostic.CA2133.severity = warning
+dotnet_diagnostic.CA2134.severity = warning
+dotnet_diagnostic.CA2137.severity = warning
+dotnet_diagnostic.CA2138.severity = warning
+dotnet_diagnostic.CA2140.severity = warning
+dotnet_diagnostic.CA2141.severity = warning
+dotnet_diagnostic.CA2146.severity = warning
+dotnet_diagnostic.CA2147.severity = warning
+dotnet_diagnostic.CA2149.severity = warning
+dotnet_diagnostic.CA2200.severity = warning
+dotnet_diagnostic.CA2202.severity = warning
+dotnet_diagnostic.CA2207.severity = warning
+dotnet_diagnostic.CA2212.severity = warning
+dotnet_diagnostic.CA2213.severity = warning
+dotnet_diagnostic.CA2214.severity = warning
+dotnet_diagnostic.CA2216.severity = warning
+dotnet_diagnostic.CA2220.severity = warning
+dotnet_diagnostic.CA2229.severity = warning
+dotnet_diagnostic.CA2231.severity = warning
+dotnet_diagnostic.CA2232.severity = warning
+dotnet_diagnostic.CA2235.severity = warning
+dotnet_diagnostic.CA2236.severity = warning
+dotnet_diagnostic.CA2237.severity = warning
+dotnet_diagnostic.CA2238.severity = warning
+dotnet_diagnostic.CA2240.severity = warning
+dotnet_diagnostic.CA2241.severity = warning
+dotnet_diagnostic.CA2242.severity = warning
+dotnet_diagnostic.CS0618.severity = suggestion
+dotnet_diagnostic.SA0001.severity = none
+dotnet_diagnostic.SA1003.severity = none
+dotnet_diagnostic.SA1008.severity = none
+dotnet_diagnostic.SA1009.severity = none
+dotnet_diagnostic.SA1012.severity = none
+dotnet_diagnostic.SA1013.severity = none
+dotnet_diagnostic.SA1100.severity = none
+dotnet_diagnostic.SA1108.severity = none
+dotnet_diagnostic.SA1110.severity = none
+dotnet_diagnostic.SA1111.severity = none
+dotnet_diagnostic.SA1116.severity = none
+dotnet_diagnostic.SA1117.severity = none
+dotnet_diagnostic.SA1119.severity = none
+dotnet_diagnostic.SA1124.severity = none
+dotnet_diagnostic.SA1127.severity = none
+dotnet_diagnostic.SA1128.severity = none
+dotnet_diagnostic.SA1131.severity = none
+dotnet_diagnostic.SA1139.severity = none
+dotnet_diagnostic.SA1201.severity = none
+dotnet_diagnostic.SA1202.severity = none
+dotnet_diagnostic.SA1203.severity = none
+dotnet_diagnostic.SA1204.severity = none
+dotnet_diagnostic.SA1214.severity = none
+dotnet_diagnostic.SA1216.severity = none
+dotnet_diagnostic.SA1217.severity = none
+dotnet_diagnostic.SA1300.severity = none
+dotnet_diagnostic.SA1402.severity = none
+dotnet_diagnostic.SA1407.severity = none
+dotnet_diagnostic.SA1413.severity = none
+dotnet_diagnostic.SA1501.severity = none
+dotnet_diagnostic.SA1502.severity = none
+dotnet_diagnostic.SA1503.severity = none
+dotnet_diagnostic.SA1512.severity = none
+dotnet_diagnostic.SA1515.severity = none
+dotnet_diagnostic.SA1520.severity = none
+# Documentation stuff that needs to be hanged to warning at some point.
+dotnet_diagnostic.SA1600.severity = none
+dotnet_diagnostic.SA1602.severity = none
+dotnet_diagnostic.SA1604.severity = none
+dotnet_diagnostic.SA1611.severity = none
+dotnet_diagnostic.SA1615.severity = none
+dotnet_diagnostic.SA1616.severity = none
+dotnet_diagnostic.SA1618.severity = none
+dotnet_diagnostic.SA1623.severity = none
+dotnet_diagnostic.SA1625.severity = none
+dotnet_diagnostic.SA1629.severity = none
+dotnet_diagnostic.SA1633.severity = none
+dotnet_diagnostic.SA1640.severity = none
+dotnet_diagnostic.SA1641.severity = none
+dotnet_diagnostic.SA1642.severity = none
+dotnet_diagnostic.SA1643.severity = none
+dotnet_diagnostic.SA1649.severity = none
+dotnet_diagnostic.SA1652.severity = none
+dotnet_diagnostic.SA1612.severity = none
+dotnet_diagnostic.SA1614.severity = none
+dotnet_diagnostic.SA1648.severity = none
+dotnet_diagnostic.SA1005.severity = none
+dotnet_diagnostic.SA1601.severity = none
+dotnet_diagnostic.SA1107.severity = none
+dotnet_diagnostic.SA1114.severity = none
+
+# CS1658: Warning is overriding an error
+dotnet_diagnostic.CS1658.severity = none
+
+# CS1573: Parameter has no matching param tag in the XML comment (but other parameters do)
+dotnet_diagnostic.CS1573.severity = none
+
+# xUnit2013: Do not use equality check to check for collection size.
+dotnet_diagnostic.xUnit2013.severity = none
+
 [*.{cs,vb}]
 dotnet_sort_system_directives_first = true

src/Blockcore.sln

@@ -70,9 +70,7 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Global", "Global", "{0C6FDCCE-6D75-441F-86FA-2AD177196BF8}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
-		Blockcore.ruleset = Blockcore.ruleset
 		Directory.Build.props = Directory.Build.props
-		None.ruleset = None.ruleset
 		stylecop.json = stylecop.json
 		test.runsettings = test.runsettings
 	EndProjectSection

src/Blockcore/.editorconfig

@@ -0,0 +1,37 @@
+# Editor configuration, see http://editorconfig.org
+
+# todo: fix styling on the classes bellow
+
+[ScriptEvaluationContext.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[Script.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[Transaction.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[TransactionBuilder.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[TransactionSignature.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[StandardScriptTemplate.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[IpExtensions.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[ValidatedAddress.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[Network.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[ScriptReader.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[NBitcoin/**.cs]
+dotnet_analyzer_diagnostic.severity = none
+

src/Blockcore/Base/Deployments/BIP9Deployments.cs

@@ -16,7 +16,7 @@ public class BIP9DeploymentsParameters
 
         // 75% of 144 blocks
         public const long DefaultRegTestThreshold = 108;
-        
+
         public BIP9DeploymentsParameters(string name, int bit, DateTimeOffset startTime, DateTimeOffset timeout, long threshold)
         {
             this.Bit = bit;
@@ -25,9 +25,9 @@ public BIP9DeploymentsParameters(string name, int bit, DateTimeOffset startTime,
             this.Threshold = threshold;
             this.Name = name.ToLower();
         }
-        
+
         public BIP9DeploymentsParameters(string name, int bit, long startTime, long timeout, long threshold)
-            : this(name, bit, (DateTimeOffset) Utils.UnixTimeToDateTime(startTime), Utils.UnixTimeToDateTime(timeout), threshold)
+            : this(name, bit, (DateTimeOffset)Utils.UnixTimeToDateTime(startTime), Utils.UnixTimeToDateTime(timeout), threshold)
         {
         }
 
@@ -53,13 +53,12 @@ public DateTimeOffset Timeout
             private set;
         }
 
-        public string Name 
+        public string Name
         {
             get;
             private set;
         }
 
-
         /// <summary>Specifies the activation threshold for this deployment. The BIP9 specification originally set the threshold at >=1916 blocks (95% of 2016),
         /// or >=1512 for testnet (75% of 2016). </summary>
         public long Threshold
@@ -68,4 +67,4 @@ public long Threshold
             private set;
         }
     }
-}
+}

src/Blockcore/Base/Deployments/BIP9DeploymentsArray.cs

@@ -10,6 +10,7 @@ namespace Blockcore.Base.Deployments
     public class BIP9DeploymentFlags
     {
         public ScriptVerify ScriptFlags { get; set; }
+
         public Transaction.LockTimeFlags LockTimeFlags { get; set; }
 
         public BIP9DeploymentFlags()

src/Blockcore/Blockcore.csproj

@@ -6,7 +6,6 @@
     <AssemblyName>Blockcore</AssemblyName>
     <PackageId>Blockcore.Core</PackageId>
     <GeneratePackageOnBuild>False</GeneratePackageOnBuild>
-    <CodeAnalysisRuleSet>..\Blockcore.ruleset</CodeAnalysisRuleSet>
     <IsPackable>true</IsPackable>
   </PropertyGroup>