Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move broadcaster from wallet to base and to mempool #113

Merged
merged 2 commits into from
May 6, 2020

Conversation

dangershony
Copy link
Member

Broadcaster has no need to be in the wallet as broadcasting can happen without wallet (in case a trx is made created of the node)

Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to refactor this out of wallet! All good!

{
Guard.NotNull(transaction, nameof(transaction));

if (this.IsPropagated(transaction))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing { }

…EventArgs, alsointroduce BroadcastCheck interface instead of overriding the broadcast manager
@dangershony dangershony merged commit aaba809 into block-core:master May 6, 2020
@dangershony dangershony deleted the move-broadcaster branch May 6, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants