Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When segwit address is used to sign, we need to return the address signed with. #142

Merged

Conversation

DennisAMenace
Copy link
Contributor

This is a follow up to PR #66 where I said:

Is there a way we can sign with the Bech32 address and not the underlying base58 address?

If there is not a better way, I would suggest that the base58 address is returned with the signature string.

This is the PR for that suggestion as that PR was committed without any further input, so this will provide a solution until a better solution is presented.

@dangershony dangershony merged commit 0c246e4 into block-core:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants