Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve structure for network definitions #246

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Improve structure for network definitions #246

merged 2 commits into from
Dec 7, 2020

Conversation

sondreb
Copy link
Member

@sondreb sondreb commented Dec 6, 2020

  • Make sure that project and folder files are named same as packages, ensure same pattern for all network definitions.
  • Remove all third party chain nodes/daemons.

@sondreb
Improve structure for network definitions
ce9946f 
- Make sure that project and folder files are named same as packages, ensure same pattern for all network definitions.
- Remove all third party chain nodes/daemons.
@sondreb sondreb requested a review from dangershony December 6, 2020 15:13
@dangershony
Copy link
Member

@sondreb when you have time to merge master so we get green tests.
Is this still wip?

@sondreb sondreb merged commit 633119f into master Dec 7, 2020
@sondreb sondreb deleted the feature/remove-chain-nodes branch December 7, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangershony dangershony Awaiting requested review from dangershony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sondreb @dangershony