Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ChainedBlocksDataBytes #338

Merged
merged 1 commit into from
May 26, 2021
Merged

Remove the ChainedBlocksDataBytes #338

merged 1 commit into from
May 26, 2021

Conversation

sondreb
Copy link
Member

@sondreb sondreb commented May 18, 2021

@sondreb
Remove the ChainedBlocksDataBytes
8c08d9d 
- "ChainedBlocksDataBytes" was not really used, but required loading of all headers on startup. Removed to improve performance from 52 seconds to 42 seconds.
- This was discovered independent of stratisproject/StratisFullNode#233, but linking to that issue to help Stratis and Blockcore-based blockchains to take the improvement.
- #337
@sondreb sondreb mentioned this pull request May 18, 2021
Open
dangershony
dangershony reviewed May 18, 2021
View reviewed changes
Copy link
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok probably best to run a full sync on some networks and full tests locally

@sondreb sondreb merged commit d95c898 into master May 26, 2021
@sondreb sondreb deleted the feature/node-performance-1 branch May 26, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangershony dangershony dangershony left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sondreb @dangershony