Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRC HardFork - X11, DigiShield POW algo #402

Merged
merged 4 commits into from May 10, 2022
Merged

XRC HardFork - X11, DigiShield POW algo #402

merged 4 commits into from May 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2022

Hello,
there was a new hardfork of XRC from block 136136 which changed algo of XRC from X13 to X11 and it is using now DigiShield POW Retarget every next block.

This pull request is there because of compatibility of Blockcore with this change.

Thank you for merge.

@dangershony
Copy link
Member

Is this an urgent PR request?

Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for the PR. There is a couple of things needed to be done:

  • Re-add the old checkpoints.
  • Provide a link to a statement or information from the XRC team/website regarding this hardfork, if available?

@ghost
Copy link
Author

ghost commented May 10, 2022

Is this an urgent PR request?

Yes, without that, blockcore node is incompatible for now.

@ghost
Copy link
Author

ghost commented May 10, 2022

Looks good and thanks for the PR. There is a couple of things needed to be done:

* Re-add the old checkpoints.

* Provide a link to a statement or information from the XRC team/website regarding this hardfork, if available?
  1. Old checkpoints are back.

  2. For example:
    https://twitter.com/MotorUp2/status/1523752003910119424?s=20&t=1UY_W7bjQu0Qiq-vmiD1_w
    https://twitter.com/MotorUp2/status/1523855657618788359?s=20&t=TTYwEODuHX44lxXKEzZtMg
    https://twitter.com/xrhodium_xrc
    https://www.xrhodium.org/
    image

@ghost
Copy link
Author

ghost commented May 10, 2022

Thank you very much for merge :)

And one more comment. I tried to compile your blockcore node under Ubuntu and there is necessary to:

sudo apt update
sudo apt install -y libc-dev librocksdb-dev

\src\Node\Blockcore.Node
dotnet add package RocksDbSharp
dotnet add package RocksDbNative

Im not sure exactly what is necessary but it helped. Your node is working under Ubuntu 20.04 with this update.

Thanks for your work. :)

Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run it and verified it works fine. Thanks for the changes after previous review.

@sondreb sondreb merged commit 59458b4 into block-core:master May 10, 2022
@sondreb
Copy link
Member

sondreb commented May 11, 2022

This has been released and updated on our public indexer and explorer: https://explorer.blockcore.net/xrc/explorer

Version 1.1.40 or higher of the multi-node is now compatible with the new consensus rules for XRC: https://github.com/block-core/blockcore-nodes/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants