Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MOL blockchain #423

Merged
merged 47 commits into from
Oct 24, 2022
Merged

Adding MOL blockchain #423

merged 47 commits into from
Oct 24, 2022

Conversation

shtah
Copy link
Contributor

@shtah shtah commented Oct 24, 2022

Adding MOL blockchain, Impleum and Mol Blockchain Seed Node Update, IMPLX and MOL Checkpoints update

{ 600000, new CheckpointInfo(new uint256("0xac64cb247ccbc3b4077c7c6489124ec8895ca33dac39ac5ab0c833657e6c9df6"), new uint256("0xe2a8cc402d5f30eaa18f4591533fc17bc0f36874bc52f011723b8f786d4d6022")) },
{ 700000, new CheckpointInfo(new uint256("0xec96224f7ea2352a158ec3af7415e37e86356951661c6d6456a998b6684c5c91"), new uint256("0xb36136b9a92fe62b8f76dd4d7df59c7ca85efd49bb8f4154f6b159926c590e7b")) },
{ 800000, new CheckpointInfo(new uint256("0x8c72571334c5ed51e9332e1ba457cff5c920d54ef9b92a36602a350ca326790d"), new uint256("0xdce78ac613c81bc1908defcd674cfe32de5186db7c0635f1789eea7a5f9a0850")) },
{ 900000, new CheckpointInfo(new uint256("0x9856449c51c92cba7a2d4ee505650b18e044e2eb8b56c300fe5700eabed9049e"), new uint256("0x89d63290966eeca6dca6144672f894bfde5b4894dd89e0f2f7cd8a94f77543de")) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with more checkpoints!

new DNSSeedData("seed1", "mol.molie.net"),
new DNSSeedData("seed2", "mol1.molie.net"),
new DNSSeedData("seed3", "mol2.molie.net"),
new DNSSeedData("seed4", "mol3.molie.net"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about IP seeds? If there are DNS issues, the clients won't be able to connect anywhere.


public static List<NetworkAddress> Nodes = new List<NetworkAddress>
{
// new NetworkAddress(IPAddress.Parse("109.108.77.134"), DefaultPort),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any IP seeds?

{ 200000, new CheckpointInfo(new uint256("0xfc9380c469d3f09aa0638ce6f6b2344322694c0958cbb7b36e80ee0e993b68d1"), new uint256("0x66156e9f4f09d69a3cee9bed6ddbdf0deac42251fa77b82c1dac558fef668275")) },
{ 300000, new CheckpointInfo(new uint256("0x398986ca2d89f7c267253e5d814663b56962fdf94f87a26c1311ec15638d81bb"), new uint256("0x50e45783c89c58cdd7a33f4823cdc49aad266d3ac110ac68825b2eea0a833bea")) },
{ 400000, new CheckpointInfo(new uint256("0x5811caef1f89a497f55135bbc244bdfc9f50c21ca9ff906f7762e81fb5eddeee"), new uint256("0x69daf3b1547b33a5b2b19ef28274054a31fcc879148c1cc4c29857e76bfb1966")) },
{ 500000, new CheckpointInfo(new uint256("0x91132a91aa24a6c2bebf90c02acbfe58def98cbab1072e0d3aec6f6873c3d7a9"), new uint256("0x902ee692a6a9f92d9eb32632f8e58399c5a4cbb256864b346e39965ea80c4135")) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

"commandName": "Project",
"commandLineArgs": "--chain=SBC -server -rpcallowip=127.0.0.1 -rpcbind=127.0.0.1 -rpcpassword=rpcpassword -rpcuser=rpcuser -datadir=nodedata -testnet"
},
"RSC (MAIN)": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're removing SBC and RSC. I can manually add those back after merge if you're not fixing it.

Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the folder all lower-case, that's by-convention to avoid issues with compatibility, etc.

internal class Test
{
public const string Name = "MolieTest";
public const string RootFolderName = "MolieTest";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this all lowercase

internal class RegTest
{
public const string Name = "MolieRegTest";
public const string RootFolderName = "MolieRegTest";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this all lowercase

internal class Main
{
public const string Name = "MolieMain";
public const string RootFolderName = "Molie";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this all lowercase

@sondreb sondreb merged commit 91eaea8 into block-core:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants