Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: secrets don't work on pull requests #134

Closed
0xneves opened this issue Dec 8, 2023 · 2 comments · Fixed by #135
Closed

fix: secrets don't work on pull requests #134

0xneves opened this issue Dec 8, 2023 · 2 comments · Fixed by #135
Assignees
@0xneves
Labels
bug Something isn't working
Milestone
Swaplace v1.0.0

Comments

@0xneves
Copy link
Contributor

0xneves commented Dec 8, 2023

By default, GitHub Actions workflows triggered by pull requests from forks do not have access to repository secrets, including private keys.

Image

Proposal:

  • add the standard deployment private key into a public variable
  • change secrets into vars on yaml files
@0xneves 0xneves added the bug Something isn't working label Dec 8, 2023
@0xneves 0xneves added this to the Swaplace v1.0.0 milestone Dec 8, 2023
@0xneves 0xneves self-assigned this Dec 8, 2023
@0xneves 0xneves added this to Swaplace Dec 8, 2023
@0xneves 0xneves moved this to 🛠️ In Progress in Swaplace Dec 8, 2023
@0xneves 0xneves mentioned this issue Dec 8, 2023
Merged
@0xneves
Copy link
Contributor Author

0xneves commented Dec 8, 2023

I'm reopening this as it is still not working for pull requests

@0xneves 0xneves reopened this Dec 8, 2023
@0xneves
Copy link
Contributor Author

0xneves commented Dec 8, 2023

Actually, it is fixed.

@0xneves 0xneves closed this as completed Dec 8, 2023
@0xneves 0xneves moved this from 🛠️ In Progress to ✅ Done in Swaplace Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xneves 0xneves

Labels
bug Something isn't working
Projects
Swaplace
Status: ✅ Done
Milestone
Swaplace v1.0.0
Development

Successfully merging a pull request may close this issue.

fix: moving from secrets into vars 0xneves/swaplace-contracts
1 participant
@0xneves