Merge pull request #1884 from blockscout/remove-security-score-experi…

…ment Remove security score experiment
blockscout · May 6, 2024 · 825a3e7 · 825a3e7
2 parents 68388c9 + 7fec8a8
commit 825a3e7
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 20 deletions.
diff --git a/lib/growthbook/init.ts b/lib/growthbook/init.ts
@@ -7,7 +7,6 @@ import { STORAGE_KEY, STORAGE_LIMIT } from './consts';
 
 export interface GrowthBookFeatures {
   test_value: string;
-  security_score_exp: boolean;
 }
 
 export const growthBook = (() => {

diff --git a/ui/marketplace/MarketplaceAppModal.tsx b/ui/marketplace/MarketplaceAppModal.tsx
@@ -7,7 +7,6 @@ import React, { useCallback } from 'react';
 import type { MarketplaceAppWithSecurityReport } from 'types/client/marketplace';
 import { ContractListTypes } from 'types/client/marketplace';
 
-import useFeatureValue from 'lib/growthbook/useFeatureValue';
 import useIsMobile from 'lib/hooks/useIsMobile';
 import { nbsp } from 'lib/html-entities';
 import * as mixpanel from 'lib/mixpanel/index';
@@ -33,7 +32,6 @@ const MarketplaceAppModal = ({
   data,
   showContractList: showContractListProp,
 }: Props) => {
-  const { value: isExperiment } = useFeatureValue('security_score_exp', false);
   const starOutlineIconColor = useColorModeValue('gray.600', 'gray.300');
 
   const {
@@ -188,7 +186,7 @@ const MarketplaceAppModal = ({
                 />
               </Flex>
 
-              { (isExperiment && securityReport) && (
+              { securityReport && (
                 <Flex alignItems="center" gap={ 3 }>
                   <AppSecurityReport
                     id={ id }

diff --git a/ui/marketplace/MarketplaceAppTopBar.tsx b/ui/marketplace/MarketplaceAppTopBar.tsx
@@ -8,7 +8,6 @@ import { route } from 'nextjs-routes';
 
 import config from 'configs/app';
 import { useAppContext } from 'lib/contexts/app';
-import useFeatureValue from 'lib/growthbook/useFeatureValue';
 import useIsMobile from 'lib/hooks/useIsMobile';
 import IconSvg from 'ui/shared/IconSvg';
 import LinkExternal from 'ui/shared/LinkExternal';
@@ -31,7 +30,6 @@ const MarketplaceAppTopBar = ({ data, isLoading, securityReport }: Props) => {
   const [ showContractList, setShowContractList ] = useBoolean(false);
   const appProps = useAppContext();
   const isMobile = useIsMobile();
-  const { value: isExperiment } = useFeatureValue('security_score_exp', false);
 
   const goBackUrl = React.useMemo(() => {
     if (appProps.referrer && appProps.referrer.includes('/apps') && !appProps.referrer.includes('/apps/')) {
@@ -72,7 +70,7 @@ const MarketplaceAppTopBar = ({ data, isLoading, securityReport }: Props) => {
         <Skeleton isLoaded={ !isLoading }>
           <MarketplaceAppInfo data={ data }/>
         </Skeleton>
-        { (isExperiment && (securityReport || isLoading)) && (
+        { (securityReport || isLoading) && (
           <AppSecurityReport
             id={ data?.id || '' }
             securityReport={ securityReport }

diff --git a/ui/pages/Marketplace.pw.tsx b/ui/pages/Marketplace.pw.tsx
@@ -46,14 +46,11 @@ test('with banner +@dark-mode', async({ render, mockEnvs, mockConfigResponse })
   await expect(component).toHaveScreenshot();
 });
 
-test('with scores +@dark-mode', async({ render, mockConfigResponse, mockEnvs, mockFeatures }) => {
+test('with scores +@dark-mode', async({ render, mockConfigResponse, mockEnvs }) => {
   const MARKETPLACE_SECURITY_REPORTS_URL = 'https://marketplace-security-reports.json';
   await mockEnvs([
     [ 'NEXT_PUBLIC_MARKETPLACE_SECURITY_REPORTS_URL', MARKETPLACE_SECURITY_REPORTS_URL ],
   ]);
-  await mockFeatures([
-    [ 'security_score_exp', true ],
-  ]);
   await mockConfigResponse('NEXT_PUBLIC_MARKETPLACE_SECURITY_REPORTS_URL', MARKETPLACE_SECURITY_REPORTS_URL, JSON.stringify(securityReportsMock));
   const component = await render(<Marketplace/>);
   await component.getByText('Apps scores').click();
@@ -95,14 +92,11 @@ test.describe('mobile', () => {
     await expect(component).toHaveScreenshot();
   });
 
-  test('with scores', async({ render, mockConfigResponse, mockEnvs, mockFeatures }) => {
+  test('with scores', async({ render, mockConfigResponse, mockEnvs }) => {
     const MARKETPLACE_SECURITY_REPORTS_URL = 'https://marketplace-security-reports.json';
     await mockEnvs([
       [ 'NEXT_PUBLIC_MARKETPLACE_SECURITY_REPORTS_URL', MARKETPLACE_SECURITY_REPORTS_URL ],
     ]);
-    await mockFeatures([
-      [ 'security_score_exp', true ],
-    ]);
     await mockConfigResponse('NEXT_PUBLIC_MARKETPLACE_SECURITY_REPORTS_URL', MARKETPLACE_SECURITY_REPORTS_URL, JSON.stringify(securityReportsMock));
     const component = await render(<Marketplace/>);
     await component.getByText('Apps scores').click();

diff --git a/ui/pages/Marketplace.tsx b/ui/pages/Marketplace.tsx
@@ -7,7 +7,6 @@ import type { TabItem } from 'ui/shared/Tabs/types';
 
 import config from 'configs/app';
 import throwOnResourceLoadError from 'lib/errors/throwOnResourceLoadError';
-import useFeatureValue from 'lib/growthbook/useFeatureValue';
 import useIsMobile from 'lib/hooks/useIsMobile';
 import Banner from 'ui/marketplace/Banner';
 import ContractListModal from 'ui/marketplace/ContractListModal';
@@ -74,7 +73,6 @@ const Marketplace = () => {
   } = useMarketplace();
 
   const isMobile = useIsMobile();
-  const { value: isExperiment } = useFeatureValue('security_score_exp', false);
 
   const categoryTabs = React.useMemo(() => {
     const tabs: Array<TabItem> = categories.map(category => ({
@@ -189,7 +187,7 @@ const Marketplace = () => {
       </Box>
 
       <Flex direction={{ base: 'column', lg: 'row' }} mb={{ base: 4, lg: 6 }} gap={{ base: 4, lg: 3 }}>
-        { (feature.securityReportsUrl && isExperiment) && (
+        { feature.securityReportsUrl && (
           <Skeleton isLoaded={ !isPlaceholderData }>
             <RadioButtonGroup<MarketplaceDisplayType>
               onChange={ onDisplayTypeChange }
@@ -226,12 +224,12 @@ const Marketplace = () => {
           onChange={ onSearchInputChange }
           placeholder="Find app by name or keyword..."
           isLoading={ isPlaceholderData }
-          size={ (feature.securityReportsUrl && isExperiment) ? 'xs' : 'sm' }
+          size={ feature.securityReportsUrl ? 'xs' : 'sm' }
           flex="1"
         />
       </Flex>
 
-      { (selectedDisplayType === MarketplaceDisplayType.SCORES && feature.securityReportsUrl && isExperiment) ? (
+      { (selectedDisplayType === MarketplaceDisplayType.SCORES && feature.securityReportsUrl) ? (
         <MarketplaceListWithScores
           apps={ displayedApps }
           showAppInfo={ showAppInfo }