Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
tom2drum committed Sep 5, 2024
1 parent f807736 commit d1cf34b
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ui/pages/OptimisticL2TxnBatch.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const OptimisticL2TxnBatch = () => {
<>
<TextAd mb={ 6 }/>
<PageTitle
title={ `Tx batch #${ number }` }
title={ `Batch #${ number }` }
backLink={ backLink }
/>
{ batchQuery.isPlaceholderData ?
Expand Down
2 changes: 1 addition & 1 deletion ui/shared/batch/OptimisticL2TxnBatchDA.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const OptimisticL2TxnBatchDA = ({ container, isLoading }: Props) => {
case 'in_blob4844':
return 'EIP-4844 blob';
case 'in_calldata':
return 'Call data';
return 'Calldata';
case 'in_celestia':
return 'Celestia blob';
}
Expand Down
6 changes: 4 additions & 2 deletions ui/txnBatches/optimisticL2/OptimisticL2TxnBatchDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ const OptimisticL2TxnBatchDetails = ({ query }: Props) => {
>
<DetailsInfoItem.Label
isLoading={ isPlaceholderData }
hint="Batch number indicates the length of batches produced by grouping L2 blocks to be proven on L1"
hint="Batch ID indicates the length of batches produced by grouping L2 blocks to be proven on L1"
>
Tx batch number
Batch ID
</DetailsInfoItem.Label>
<DetailsInfoItem.Value>
<Skeleton isLoaded={ !isPlaceholderData }>
Expand Down Expand Up @@ -106,6 +106,7 @@ const OptimisticL2TxnBatchDetails = ({ query }: Props) => {
<LinkInternal href={ route({ pathname: '/batches/[number]', query: { number: data.internal_id.toString(), tab: 'txs' } }) }>
{ data.tx_count.toLocaleString() } transaction{ data.tx_count === 1 ? '' : 's' }
</LinkInternal>
{ ' ' }in this batch
</Skeleton>
</DetailsInfoItem.Value>

Expand All @@ -120,6 +121,7 @@ const OptimisticL2TxnBatchDetails = ({ query }: Props) => {
<LinkInternal href={ route({ pathname: '/batches/[number]', query: { number: data.internal_id.toString(), tab: 'blocks' } }) }>
{ blocksCount.toLocaleString() } block{ blocksCount === 1 ? '' : 's' }
</LinkInternal>
{ ' ' }in this batch
</Skeleton>
</DetailsInfoItem.Value>

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit d1cf34b

Please sign in to comment.