Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time incoming transactions are sorted incorrectly #1681

Closed
k1rill-fedoseev opened this issue Mar 7, 2024 · 0 comments · Fixed by #1720
Closed

Real-time incoming transactions are sorted incorrectly #1681

k1rill-fedoseev opened this issue Mar 7, 2024 · 0 comments · Fixed by #1720
Assignees
Labels
bug Something isn't working v1.27.0 Release v1.27.0

Comments

@k1rill-fedoseev
Copy link
Member

On pages like https://eth.blockscout.com/address/0xdAC17F958D2ee523a2206206994597C13D831ec7?tab=txs , transactions added to the list in real time are inserted to the beginning of the list, breaking the logical order with pending transactions.

Pending transactions should always be placed on the tip of the list.

image
@k1rill-fedoseev k1rill-fedoseev added the bug Something isn't working label Mar 7, 2024
@tom2drum tom2drum self-assigned this Mar 18, 2024
tom2drum added a commit that referenced this issue Mar 19, 2024
* Real-time incoming transactions are sorted incorrectly

Fixes #1681

* fix checks workflow
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.27.0 Release v1.27.0 and removed pre-release Tasks in pre-release right now labels Mar 19, 2024
Wolmin added a commit to lukso-network/network-explorer-execution-frontend that referenced this issue Apr 9, 2024
* temporary disable focus reset

* remove marketplace experiment

* remove unused components

* update screenshots

* fix

* fix interpretation checks

* add method call as tx interpretation

* trying to fix problem with affected tests file download

* [skip ci] optimize affected tests script

* sort dapps by favorite

* fix csp policy for hype

* fix label for "Add public tag"

* Fix RSK stats - transaction fees precision (blockscout#1602)

* Fix RSK stats - transaction fees precision

Fixes blockscout#1473

* update screenshot

* Fix broken link in ENVS.md

* add NEXT_PUBLIC_MARKETPLACE_ENABLED env var

* update schema

* enable marketplace in pw tests

* add an explanatory comment

* fix script

* Validators list (blockscout#1621)

* new ENV and page placeholder

* display list data

* comment out SearchInput

* add counters

* add tag to address page

* tests

* refactoring

* fix ts

* change ENVs for demo

* fix ENVs validator

* [skip ci] remove hash

* review fixes

* [skip ci] out out parallel tests in local env

* shibarium deposits and withdrawals

* review fixes

* contract audits

* tests

* tests

* fix schema

* try to remove scroll artifacts

* remove double fetch

* better mock

* review fixes

* Gas tracker page (blockscout#1524)

* add custom headers to API resource

* refactoring

* page title

* chart

* gas prices snippet

* GasPrice component

* add ENV for gas units

* dark theme and other tweaks

* tests

* add base and priority fee

* [skip ci] small fiat values

* change behavior of the variable

* update tooltip layout

* refactor gas info tooltip

* refactor GasPrice component

* fix logic and deploy demo for eth mainnet

* tests

* remove link from anchor

* [skip ci] rollback ENVs for demo

* review fixes

* fix tests

* `outputs` field is not required for contract read method

Fixes blockscout#1624

* rename apps to dapps

* update screenshots

* add ads for GasTracker page test

* add top bar to dapp page

* fix github links in MarketplaceAppModal

* fix envs-validator

* fix csp for marketplace

* update search bar screenshot

* typo: incorrect yarn dev preset command

* add mixpanel events to operations in dapps

* Not possible to remove address filter in token inventory for an address with no NFTs

Fixes blockscout#1514

* OG description bug for NFT instances

Fixes blockscout#1578

* fix navigation reset

* Add a decimal part to the Market cap graph value and handle null values

* update screenshot for home page

* Display arrays of structs on Read/Write contract tabs (blockscout#1556)

* prototype

* change host for preview

* improve labels for nested arrays

* add field path

* bind fields to react form

* transform form fields into method args

* add styles for non-array args

* styles for tuple array

* style nested array inputs

* clear and multiply buttons for inputs

* show errors in inputs

* pass disabled state to inputs

* change direction of accordioin icon

* remove old code

* add asterix to required fields

* improvements and comments

* change styles

* highlight sections with errors

* refactoring field method name

* fix lable color

* fix ts

* preliminary tests

* better complex field labels

* improve tests

* remove outputs for write methods

* rollback review value

* post-review changes

* add mixpanel event for swap button

* fix initial dapp sorting

* post-review changes and style fix

* remove margin

* validators state filter fix

* fix gas price snippet in chrome

* update gas tracker page screenshots

* add test for marketplace page

* remove title second raw gap

* fix block table layout
h ick 7b395881 up node version to 18

* remove title second raw gap

* fix block table layout
h ick 7b395881 up node version to 18

* improve marketplace tests

* add test for app info dropdown

* add test for marketplace app modal

* Fix message shown when there are no deposits on L2

* upgrade dappscout-iframe

* post-review changes

* fix conflict

* truncate domain in domains popup (blockscout#1645)

Fixes blockscout#1644

* Update Safe wallets networks config (blockscout#1654)

Fixes blockscout#1626

* improve perf of highlighting same address in lists (blockscout#1662)

Fixes blockscout#1661

* add fallback for NFT animation media

* Contract: License (blockscout#1668)

* display license on contract page and in the list

* add new field to the form

* review fixes

* fix typo

* Support raw format of v0.7 user ops

* Handle undefined timestamp for zkEVM batch

Fixes blockscout#1674

* Add Blobs support (EIP-4884) (blockscout#1672)

* blob page placeholder

* txs with blobs list view

* tx additional info popup

* blob gas info for tx and block

* update hints

* tx blobs tab

* blob details page

* add ENV to hide blob txs tab

* tx blob fees and adj for tx burnt fees

* preliminary tests

* blob data convertion

* display blob data type in lists

* download asset

* blob txs in block

* tests for blob data preview

* fixes

* fix tests

* support blobs in search

* update blob icon

* more fixes

* highlight code of the main contract

Fixes blockscout#1676

* change api host for demo

* add user ops tx interpretation

* [skip ci] rollback demo env

* Metasuites placeholders (blockscout#1637)

* placeholders for address and txs

* placeholder for explorer link

* move phalcon link

* change api endpoint for demo

* Fixing upstream header too large

* ready flags and navigation events

* add ENV

---------

Co-authored-by: Nick Zenchik <n.zenchik@gmail.com>

* fix blob page tests

* handle blobs with no data

* fix connect wallet message

* fix dapps sorting

* add new view with scores for marketplace

* make solidityscan report component reusable

* fix contract method form fields value foramatting

* rename validator status "failed" into "inactive"

* update screenshots

* Revert "update screenshots"

This reverts commit 93098f5.

* update screenshots for MarketplaceApp

* fix useMarketplaceApps hook

* another fix

* remove mobile test

* replace ref with state to fix test

* getit test

* update sdk

* update sdk 2

* error-demo

* update sdk 3

* remove 404 for blob page if blob txs view is hidden

* add security score component, integrate real data

* create contract list modal

* fix blob image parsing

* blob: don't break words for UTF-8 decoding

* add test

* contract method: format all args to string

* change api for demo

* fix contract list modal for mobiles

* update link buttons, add tooltip, update modal title

* add beta label

* fix search input margin on mobile

* move MoreInfo button to separate component

* move components

* add reports to apps inside hook

* rework AppSecurityReport

* add security score to marketplace app modal

* use ids instead of network names

* replace type

* Update values.yaml.gotmpl

* add new env to docs and validator

* add marketplace config url for review deployment

* metadata date fix

* Incorrect NFT media placeholder when navigating between pages

Fixes blockscout#1710

* fix token icon fallback

* 404 for unknown transaction (blockscout#1697)

* 404 for unknown transaction

Fixes blockscout#1689

* add helper for displaying custom error screen

* Remove the use of the token object from the response of the `api/v2/tokens/<address>/holders` endpoint. (blockscout#1696)

Fixes blockscout#1690

* Add a banner to the My Verified Addresses page (blockscout#1695)

* Add a banner to the My Verified Addresses page

Fixes blockscout#1688

* [skip ci] change text copy

* bugfix: No number wrap on the address 'Tokens' tab (blockscout#1691)

* No number wrap on the address 'Tokens' tab

Fixes blockscout#1673

* fix address overlapping in tx state

* design fixes

* display apps without security score

* add security score to dapp page

* change format of security reports data

* Dim out page to focus on a search (blockscout#1711)

* Dim out page to focus on a search

Fixes blockscout#1682

* add backdrop to search results page

* refactoring

* solidity scan icon

* change icon folder

* stats price diff on the homepage

* bugfix: Real-time incoming transactions are sorted incorrectly (blockscout#1720)

* Real-time incoming transactions are sorted incorrectly

Fixes blockscout#1681

* fix checks workflow

* bugfix: Cannot convert string to buffer while write to the contract (blockscout#1724)

Fixes blockscout#1717

* fix react keys for withdrawals

* add skeletons

* fix dapp page top bar for mobiles

* enable email for wallet connect

* fix star icon size

* wrap new components in A/B testing

* rework view switch to use url param and add skeleton

* update no data component

* fix wording for 1 item

* update empty search result

* turn off experiment by default

* update search input placeholder

* add button to tx not found error screen

* replace label with svg

* rename url param

* add mixpanel events

* Update .env.main

* fix warnings

* update star icon

* fix star icon color

* update screenshots

* hide new features

* Update MarketplaceApp.pw.tsx_default_mobile-base-view-1.png

* add security report type

* update envs-validator schema

* chore: fix typos

* update `web3modal` to v4 (blockscout#1731)

* update hooks and methods

* fix typescript

* options fix

* fix pw test build

* try to fix tests

* more pw test fixes

* update screenshots and fix address verification test

* fix types

* remove commented code

* post-review changes

* rework solidity report component

* add test for marketplace with security scores

* hide login page if no proxy needed

* upgrade dappscout-iframe

* Add AdButler as an additional ad provider

* test fixes

* Noves integration (blockscout#1398)

* noves integration

* code refactored

* PR changes added

* Code set up for new proxy 'describeTxs'

* minor fix

* Rename Novestranslate.ts to NovesTranslate.ts

* some quick stuff

* partial fixes and commit for changing how useDescribeTxs and txsContent work (new GET endpoint)

* Pending PR fixes

* tx asset flows pageSize of 50

* PR comments fixes

* rename expected api endpoint for the describe_txs endpoint, more accurate and descriptive

* one final re-name for api endpoint (make it clear it's an object vs an action)

* scrollRef fix

* build error fix

* design fixes

* sub heading fix

* Removed pagination in account history

* remove duplicate route

* updated table theme and icon gap

* Removed wrong color in table

* removed null validation in page params

* updated margin

* margin fix

* add icons to contracts

* Sub-heading interpretation simplified

* token alignment fix

* tests added for new functions

* margin fix

* remove divider on mobile asset flows

---------

Co-authored-by: NahuelNoves <Nahuel@noves.fi>
Co-authored-by: francisco-noves <francisco@noves.fi>

* add back button

* fix height of modal header

* change ENV for blob txs (blockscout#1751)

* zkSync batches (blockscout#1743)

* dev preset

* batches page

* batch details view

* batch txs

* adjustments in block view

* adjustments in tx view

* adjustments on home page

* fixes

* tests

* add pagination to batch txs

* ENV values for demo

* fix layout on batch details tab

* add more fields to batch details

* update screenshots

* revert demo ENVs

* ad provider fix

* ad provider fix 2

* Add support of ERC-404 type

* type fixes

* fixes

* tests

* fix

* test fix

* [skip ci] fix error when creating wagmi config

* Playwright tests refactoring, pt.1 (blockscout#1744)

* abort all requests for external resources and single mock for text ad

* render and mockApiResponse fixtures

* move fixtures into separate files

* rewrite Blocks test

* refactor mockApiResponse signature

* test with auth

* rewrite test with other API domains

* fix test

* separate script for installing deps in pw docker

* Numbers over 16(?) digits are rounded in contract method fields (blockscout#1761)

* Numbers over 16(?) digits are rounded in contract method fields

Fixes blockscout#1750

* Update values.yaml.gotmpl

Changed public rpc to Sepolia

* Set NEXT_PUBLIC_NETWORK_ID

---------

Co-authored-by: Yan Vaskov <72267126+yvaskov@users.noreply.github.com>

* User settings for address icons type (blockscout#1763)

* color theme settings

* address icon settings

* update tests

* add images to the address icon settings

* update styles

* more fixes

* [skip ci] fix error with color mode cookie

* [skip ci] update web3modal to next minor version

* [skip ci] update docs

---------

Co-authored-by: tom <tom@ohhhh.me>
Co-authored-by: Max Alekseenko <nnwen0609@gmail.com>
Co-authored-by: isstuev <natix.naf@gmail.com>
Co-authored-by: Igor Stuev <108066576+isstuev@users.noreply.github.com>
Co-authored-by: bap2pecs <111917526+bap2pecs@users.noreply.github.com>
Co-authored-by: Ryan Waldon <ryanpwaldon@gmail.com>
Co-authored-by: Iago Lluque <iago.lluque@iovlabs.org>
Co-authored-by: Nick Zenchik <n.zenchik@gmail.com>
Co-authored-by: isstuev <isstuev@gmail.com>
Co-authored-by: snoppy <michaleli@foxmail.com>
Co-authored-by: Juan Leandro Costa <83667708+juanlenoves@users.noreply.github.com>
Co-authored-by: NahuelNoves <Nahuel@noves.fi>
Co-authored-by: francisco-noves <francisco@noves.fi>
Co-authored-by: Yan Vaskov <72267126+yvaskov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.27.0 Release v1.27.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants