Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gas tracker UI resilient to zero values #1863

Closed
yvaskov opened this issue Apr 25, 2024 · 0 comments · Fixed by #1881
Closed

Make gas tracker UI resilient to zero values #1863

yvaskov opened this issue Apr 25, 2024 · 0 comments · Fixed by #1881
Assignees
@tom2drum
Labels
bug Something isn't working v1.30.0 Release v1.30.0

Comments

@yvaskov
Copy link
Contributor

yvaskov commented Apr 25, 2024

Description

We need to make sure that all gas tracker elements can handle zero values from the backend /api/v2/stats.
Currently gas tracker page and gas tracker widget elements are not rendered correctly if backend returns 0.0.

"base_fee"
"price"
"priority_fee"
"time"
"network_utilization_percentage"

Examples

"priority_fee": 0.0
Image

"network_utilization_percentage": 0.0
Image

Version

v1.29.1
@yvaskov yvaskov added the bug Something isn't working label Apr 25, 2024
@tom2drum tom2drum mentioned this issue May 3, 2024
Merged
4 tasks
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.30.0 Release v1.30.0 and removed pre-release Tasks in pre-release right now labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom2drum tom2drum

Labels
bug Something isn't working v1.30.0 Release v1.30.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor bug fixes blockscout/frontend
2 participants
@tom2drum @yvaskov