Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View all results button in search results opens a page from check-redirect #2077

Closed
yvaskov opened this issue Jul 8, 2024 · 1 comment · Fixed by #2160
Closed

View all results button in search results opens a page from check-redirect #2077

yvaskov opened this issue Jul 8, 2024 · 1 comment · Fixed by #2160
Assignees
Labels
bug Something isn't working v1.34.0 Release v1.34.0

Comments

@yvaskov
Copy link
Contributor

yvaskov commented Jul 8, 2024

Description

If /api/v2/search/check-redirect returns a result for the search query, View all results button redirects to that page instead of opening Search results page.

Image

Steps to reproduce

  1. Open https://eth.blockscout.com/
  2. Search for 123 or vitalik.eth
  3. Click on View all results

Version

v1.32.0

@yvaskov yvaskov added the bug Something isn't working label Jul 8, 2024
@isstuev
Copy link
Collaborator

isstuev commented Jul 8, 2024

@NikitaSavik @ulyanas what would be the right scenario here?

"view all" links to the search results page, that has a redirect check. API returns redirect to the block page so we redirect user there. Pressing "enter" does the same. If we want for some reason to have different behavior for "enter" and "view all" we can implement some url param for example, but would it make sense?

does it look ok for a user that we have redirect here? If I type "123" and see tokens in the first 10 results and press enter -- I will be redirected to the "123" block page.

@isstuev isstuev self-assigned this Aug 9, 2024
@github-actions github-actions bot added the pre-release Tasks in pre-release right now label Aug 28, 2024
@github-actions github-actions bot added v1.34.0 Release v1.34.0 and removed pre-release Tasks in pre-release right now labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.34.0 Release v1.34.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants