Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract interaction improvements #1875

Merged
merged 12 commits into from
May 6, 2024
Merged

Contract interaction improvements #1875

merged 12 commits into from
May 6, 2024

Conversation

tom2drum
Copy link
Collaborator

@tom2drum tom2drum commented May 1, 2024 •
edited
Loading

Description and Related Issue(s)

  • Add contract method id tag
  • Simulate write method call
  • Fix bug with WEI checkbox

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@tom2drum tom2drum self-assigned this May 1, 2024
This was linked to issues May 1, 2024
Contract method id tag and simulate write method call #1834
Closed
Broken WEI/ETH toggle in contract read methods #1857
Closed
@tom2drum tom2drum requested a review from isstuev May 1, 2024 13:59
@tom2drum tom2drum added the QA Pull requests requiring manual QA. label May 6, 2024
@tom2drum tom2drum merged commit 8b42923 into main May 6, 2024
10 checks passed
@tom2drum tom2drum deleted the tom2drum/issue-1834 branch May 6, 2024 17:12
DaMandal0rian pushed a commit to autonomys/blockscout-frontend that referenced this pull request May 6, 2024
@tom2drum @DaMandal0rian
Contract interaction improvements (blockscout#1875)
f812b89 
* add contract method id tag

* add form submit type

* refactor types for SmartConstract and make new component for Contract ABI methods

* move contract method form inside ABI folder

* handle form submit and display result

* clean-up

* change copied text

* handle case when blockchain interaction is not configured

* tests and screenshots update

* fix bug wit WEI checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isstuev isstuev isstuev approved these changes

Assignees

@tom2drum tom2drum

Labels
QA Pull requests requiring manual QA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken WEI/ETH toggle in contract read methods Contract method id tag and simulate write method call
2 participants
@tom2drum @isstuev