Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace '--chmod=+x' with '--chmod=755' for 'COPY' instructions in Dockerfile to be podman-friendly #2119

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

fullkomnun
Copy link
Contributor

Description and Related Issue(s)

Usage of COPY instructions with '--chmod=+x' works with docker (if buildkit is enabled) but not with podman

Proposed Changes

Replace '--chmod=+x' with '--chmod=755' for 'COPY' instructions in Dockerfile to be podman-friendly while still supporting docker

Breaking or Incompatible Changes

Should not break build of container image with docker/podman

Additional Information

Could not test on Windows 10/11 with WSL2 to verify

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@tom2drum tom2drum merged commit ff019b4 into blockscout:main Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants